From patchwork Mon Jun 13 22:03:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sripada, Radhakrishna" X-Patchwork-Id: 9174465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 647D56044F for ; Mon, 13 Jun 2016 22:03:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55D3527C0C for ; Mon, 13 Jun 2016 22:03:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A59327D07; Mon, 13 Jun 2016 22:03:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5B0327C0C for ; Mon, 13 Jun 2016 22:03:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF1EE6E689; Mon, 13 Jun 2016 22:02:59 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 63C176E689; Mon, 13 Jun 2016 22:02:57 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 13 Jun 2016 15:02:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,468,1459839600"; d="scan'208";a="996892198" Received: from invictus.jf.intel.com ([10.7.198.166]) by orsmga002.jf.intel.com with ESMTP; 13 Jun 2016 15:02:57 -0700 From: Radhakrishna Sripada To: intel-gfx@lists.freedesktop.org, drm-intel-fixes@lists.freedesktop.org Date: Mon, 13 Jun 2016 15:03:16 -0700 Message-Id: <1465855396-23851-1-git-send-email-radhakrishna.sripada@intel.com> X-Mailer: git-send-email 1.9.1 Cc: arthur.j.runyan@intel.com Subject: [Intel-gfx] [PATCH] drm/i915/skl: Increase cursor ddb blocks in multi-pipe config X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The bspec suggests giving cursor planes a fixed allocation of 8 blocks when running in a multi-CRTC configuration. However we have found that this small allocation can only accommodate level 0 watermarks on many platforms, which in turn prevents the system from entering deeper sleep states. Let's use a slightly higher allocation of 16 blocks for the cursor to increase our chances of enabling lower power states. Signed-off-by: Radhakrishna Sripada Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 658a756..a949dac 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -2933,7 +2933,8 @@ static unsigned int skl_cursor_allocation(int num_active) if (num_active == 1) return 32; - return 8; + /* higher than bspec recommendation (8) */ + return 16; } static void skl_ddb_entry_init_from_hw(struct skl_ddb_entry *entry, u32 reg)