diff mbox

drm/i915: Correct pipe fault reporting string

Message ID 1477572512-4030-1-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Oct. 27, 2016, 12:48 p.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Newline somehow ended up in the middle of the line.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ville Syrjälä Oct. 27, 2016, 12:53 p.m. UTC | #1
On Thu, Oct 27, 2016 at 01:48:32PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Newline somehow ended up in the middle of the line.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 9111cfdf217a..88239e1b29e4 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2503,7 +2503,7 @@ gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
>  			fault_errors &= GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
>  
>  		if (fault_errors)
> -			DRM_ERROR("Fault errors on pipe %c\n: 0x%08x",
> +			DRM_ERROR("Fault errors on pipe %c: 0x%08x\n",
>  				  pipe_name(pipe),
>  				  fault_errors);
>  	}
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Chris Wilson Oct. 27, 2016, 12:56 p.m. UTC | #2
On Thu, Oct 27, 2016 at 01:48:32PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Newline somehow ended up in the middle of the line.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Tvrtko Ursulin Oct. 27, 2016, 2:09 p.m. UTC | #3
On 27/10/2016 14:16, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Correct pipe fault reporting string
> URL   : https://patchwork.freedesktop.org/series/14478/
> State : success
>
> == Summary ==
>
> Series 14478v1 drm/i915: Correct pipe fault reporting string
> https://patchwork.freedesktop.org/api/1.0/series/14478/revisions/1/mbox/
>
> Test gem_ctx_switch:
>         Subgroup basic-default:
>                 timeout    -> PASS       (fi-bsw-n3050)
>         Subgroup basic-default-heavy:
>                 incomplete -> PASS       (fi-bsw-n3050)
>
> fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15
> fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42
> fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31
> fi-byt-n2820     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36
> fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22
> fi-hsw-4770r     total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23
> fi-ilk-650       total:246  pass:185  dwarn:0   dfail:0   fail:0   skip:61
> fi-ivb-3520m     total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26
> fi-ivb-3770      total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26
> fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24
> fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
> fi-skl-6700hq    total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23
> fi-skl-6700k     total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23
> fi-skl-6770hq    total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
> fi-snb-2520m     total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37
> fi-snb-2600      total:246  pass:208  dwarn:0   dfail:0   fail:0   skip:38
>
> 418b28c2fc2812aff227b273f400bf611c4e7dff drm-intel-nightly: 2016y-10m-27d-08h-38m-08s UTC integration manifest
> f7faa8d drm/i915: Correct pipe fault reporting string

Merged to dinq, thanks for the reviews!

Regards,

Tvrtko
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 9111cfdf217a..88239e1b29e4 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2503,7 +2503,7 @@  gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
 			fault_errors &= GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
 
 		if (fault_errors)
-			DRM_ERROR("Fault errors on pipe %c\n: 0x%08x",
+			DRM_ERROR("Fault errors on pipe %c: 0x%08x\n",
 				  pipe_name(pipe),
 				  fault_errors);
 	}