From patchwork Sat Dec 3 01:03:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Turner X-Patchwork-Id: 9459461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A847F6074E for ; Sat, 3 Dec 2016 01:03:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9919A28584 for ; Sat, 3 Dec 2016 01:03:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8E22928599; Sat, 3 Dec 2016 01:03:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D963528584 for ; Sat, 3 Dec 2016 01:03:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6D4F6E013; Sat, 3 Dec 2016 01:03:17 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id C908B6E013 for ; Sat, 3 Dec 2016 01:03:16 +0000 (UTC) Received: by mail-pg0-x242.google.com with SMTP id x23so9359555pgx.3 for ; Fri, 02 Dec 2016 17:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=AW6TF2zmPZyTkbUx1cu1KSZTiSXd5RFcLqqTRszOp3I=; b=EbESSnt0+QYQe9o6CGps2Q/4n9RB1QBdw9H3Ad3bKxZkyF5ikW4fh29/5nLCOqD15L MKob4qt5pMhg3rzpd11vmWvHPR2B/vKaxQM76K3raoFPhNEswOFYB1K9CeLoz0HrPypr kiAiwHwd32a2ldQ2kGUlrQqvRO4TEuNrpWXz1dpShjpvF7kNm9lKgE8En8Z+xBIu23PH Fw0E5gV86pkrIK7TnAzDnZLm/dk0/rWYFtON3V2EaVNm/fpLD9F1IVWlsy3DbbarXWuu gIvaBGB1RYM69G/0LtGJ6mA90FRC19PB4B8MulA2JwNX6kq+iRuKkSUCiQ1B2z8jZej1 UcSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AW6TF2zmPZyTkbUx1cu1KSZTiSXd5RFcLqqTRszOp3I=; b=f7jL1KFLmT7aPvRnd+43w7fxMTG7cMvm5TLIa/AmfjfBV2zDEXBcb3qNa0+I3cxNtu jjklVX4cCGX4die/Ye4776TnaozWStSYHxnsU4793adMgAMEtg18ygzVGG4LS4C8jWeA eBHwdRsQj73KQhrI5HsP5wYCPUpwZbgg0wGE6Jcw4vyuLQF8xF8GLFa7PT1FyH9SNQw9 Of/pzXj6f/gx1tVONo5cNjyxNa+QKsF5DNSKs1dRJ72eiDGpd+UyjOfWirzo8xY2rDU1 jPIm9jQT4f+oCBrsOvdOhVJBMKE/7IupS5056ynySWK2hK6JGWIzu6pFLeCoYhJB/CtN 9udA== X-Gm-Message-State: AKaTC027tYIhRMBrYJANyUEsiR9LP6b//cwErsghJPqUds30IuRgWZi1oUEE/GSZ8/OWKw== X-Received: by 10.84.173.195 with SMTP id p61mr102182136plb.68.1480726996269; Fri, 02 Dec 2016 17:03:16 -0800 (PST) Received: from localhost ([108.161.26.224]) by smtp.gmail.com with ESMTPSA id v76sm10220003pfk.77.2016.12.02.17.03.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Dec 2016 17:03:15 -0800 (PST) From: Matt Turner To: intel-gfx@lists.freedesktop.org Date: Fri, 2 Dec 2016 17:03:05 -0800 Message-Id: <1480726985-12762-1-git-send-email-mattst88@gmail.com> X-Mailer: git-send-email 2.7.3 Cc: linux-kernel@vger.kernel.org, Kenneth Graunke , Daniel Vetter , Mika Kuoppala Subject: [Intel-gfx] [PATCH] drm/i915: Remove instructions to file a bug report. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP From these instructions, users assume that /sys/class/drm/card0/error contains all the information a developer needs to diagnose and fix a GPU hang. In fact it doesn't, and we have no tools for solving them (other than stabbing in the dark). Most of the time the error state itself isn't even useful because it just shows a hang on a PIPE_CONTROL or similar. Until a time when the error state contains enough information to actually solve a hang, stop telling users to file unsolvable bugs, and instead rely on users who know where and how to file a good bug report to find their own way there. Signed-off-by: Matt Turner --- Maybe now's a good time to discuss what *would* be useful to put in the error state for debugging hangs. The currently executing shader program would be a great place to start. drivers/gpu/drm/i915/i915_gpu_error.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 334f15d..8ddca7b 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -1431,7 +1431,6 @@ void i915_capture_error_state(struct drm_i915_private *dev_priv, u32 engine_mask, const char *error_msg) { - static bool warned; struct drm_i915_error_state *error; unsigned long flags; @@ -1475,16 +1474,6 @@ void i915_capture_error_state(struct drm_i915_private *dev_priv, i915_error_state_free(&error->ref); return; } - - if (!warned) { - DRM_INFO("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); - DRM_INFO("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); - DRM_INFO("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); - DRM_INFO("The gpu crash dump is required to analyze gpu hangs, so please always attach it.\n"); - DRM_INFO("GPU crash dump saved to /sys/class/drm/card%d/error\n", - dev_priv->drm.primary->index); - warned = true; - } } void i915_error_state_get(struct drm_device *dev,