diff mbox

drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc

Message ID 1485843518-28438-1-git-send-email-dhinakaran.pandiyan@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dhinakaran Pandiyan Jan. 31, 2017, 6:18 a.m. UTC
drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
but documentation claims otherwise, fix that.

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 drivers/gpu/drm/drm_atomic.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Daniel Vetter Jan. 31, 2017, 8:34 a.m. UTC | #1
On Mon, Jan 30, 2017 at 10:18:38PM -0800, Dhinakaran Pandiyan wrote:
> drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
> but documentation claims otherwise, fix that.
> 
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

Indeed, thanks for the fix, applied to drm-misc.
-Daniel
> ---
>  drivers/gpu/drm/drm_atomic.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 78b54df..25944ab 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -322,9 +322,8 @@ static s32 __user *get_out_fence_for_crtc(struct drm_atomic_state *state,
>   * @state: the CRTC whose incoming state to update
>   * @mode: kernel-internal mode to use for the CRTC, or NULL to disable
>   *
> - * Set a mode (originating from the kernel) on the desired CRTC state. Does
> - * not change any other state properties, including enable, active, or
> - * mode_changed.
> + * Set a mode (originating from the kernel) on the desired CRTC state and update
> + * the enable property.
>   *
>   * RETURNS:
>   * Zero on success, error code on failure. Cannot return -EDEADLK.
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 78b54df..25944ab 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -322,9 +322,8 @@  static s32 __user *get_out_fence_for_crtc(struct drm_atomic_state *state,
  * @state: the CRTC whose incoming state to update
  * @mode: kernel-internal mode to use for the CRTC, or NULL to disable
  *
- * Set a mode (originating from the kernel) on the desired CRTC state. Does
- * not change any other state properties, including enable, active, or
- * mode_changed.
+ * Set a mode (originating from the kernel) on the desired CRTC state and update
+ * the enable property.
  *
  * RETURNS:
  * Zero on success, error code on failure. Cannot return -EDEADLK.