| Message ID | 1486047300-13198-1-git-send-email-matthew.auld@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 02, 2017 at 02:55:00PM +0000, Matthew Auld wrote: > Now that we have selftests in place exercising truly huge allocations > we will start to hit the 512GB warning, so now seems like a good time to > remove it. Hey! I wrote userspace tests to hit this WARN() a couple of years ago ;) -Chris
On to, 2017-02-02 at 14:55 +0000, Matthew Auld wrote: > Now that we have selftests in place exercising truly huge allocations > we will start to hit the 512GB warning, so now seems like a good time to > remove it. > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Matthew Auld <matthew.auld@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Chris, could you merge this? Regards, Joonas
On Fri, Feb 03, 2017 at 11:03:15AM +0200, Joonas Lahtinen wrote: > On to, 2017-02-02 at 14:55 +0000, Matthew Auld wrote: > > Now that we have selftests in place exercising truly huge allocations > > we will start to hit the 512GB warning, so now seems like a good time to > > remove it. > > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Signed-off-by: Matthew Auld <matthew.auld@intel.com> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Chris, could you merge this? Done. -Chris
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 048040efc3f0..c567b34800cf 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -1423,10 +1423,6 @@ static int gen8_alloc_va_range_4lvl(struct i915_address_space *vm, if (ret) return ret; - WARN(bitmap_weight(new_pdps, GEN8_PML4ES_PER_PML4) > 2, - "The allocation has spanned more than 512GB. " - "It is highly likely this is incorrect."); - gen8_for_each_pml4e(pdp, pml4, start, length, pml4e) { WARN_ON(!pdp);
Now that we have selftests in place exercising truly huge allocations we will start to hit the 512GB warning, so now seems like a good time to remove it. Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Matthew Auld <matthew.auld@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ---- 1 file changed, 4 deletions(-)