From patchwork Wed Jun 7 09:37:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 9771047 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 62DD260350 for ; Wed, 7 Jun 2017 09:37:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A9CB28471 for ; Wed, 7 Jun 2017 09:37:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4CBC42624B; Wed, 7 Jun 2017 09:37:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B27902624B for ; Wed, 7 Jun 2017 09:37:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B4FA6E21E; Wed, 7 Jun 2017 09:37:57 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C7DA66E21E for ; Wed, 7 Jun 2017 09:37:55 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 07 Jun 2017 02:37:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,310,1493708400"; d="scan'208";a="96543496" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga002.jf.intel.com with ESMTP; 07 Jun 2017 02:37:52 -0700 Message-ID: <1496828271.22624.38.camel@linux.intel.com> From: Andy Shevchenko To: "Williams, Dan J" , "hch@lst.de" Date: Wed, 07 Jun 2017 12:37:51 +0300 In-Reply-To: <1496816744.6978.6.camel@intel.com> References: <20170605164046.82676-1-andriy.shevchenko@linux.intel.com> <20170605164046.82676-2-andriy.shevchenko@linux.intel.com> <1496682642.22624.23.camel@linux.intel.com> <20170605212250.GA3772@lst.de> <1496816744.6978.6.camel@intel.com> Organization: Intel Finland Oy X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Cc: "intel-gfx@lists.freedesktop.org" , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "bp@suse.de" , "mika.westerberg@linux.intel.com" Subject: Re: [Intel-gfx] [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2017-06-07 at 06:25 +0000, Williams, Dan J wrote: > On Mon, 2017-06-05 at 23:22 +0200, Christoph Hellwig wrote: > > On Mon, Jun 05, 2017 at 08:10:42PM +0300, Andy Shevchenko wrote: > > > > > > I hope Christoph can replace old version of this series with new > > > one in > > > his uuid branch. URL in cover letter, repeating for your > > > convenience: > > > > > > [1]: git://git.infradead.org/users/hch/uuid.git > > > > Yeah, but I had to drop it again after noticing the guid_equals > > bits, > > and after not fixing up the GUID -> GUID_INIT rename. > > > > for-next in the above repo should have the proper base now, and acpi > > has the ACPI bits for Dan to test. > > With one compile fix below the 'acpi' branch works for me. Please feel > free to add: > > Tested-by: Dan Williams Thanks, Dan! I probably missed some configuration option since I have done compilation many times. > > ...to the changes that touch drivers/acpi/nfit/, drivers/nvdimm/, and > tools/testing/nvdimm, but I'm ok if you omit it if the branch is about > to go immutable. Speaking of which, let me know when it does go > immutable because the new libnvdimm enabling for ACPI 6.2 and EFI 2.7 > needs some new guid handling code. > > Please apply the following or fold it into commit c793ed7ccf42 "ACPI: > Switch to use generic guid_t in acpi_evaluate_dsm()" It think we may fold it. Besides that we might need the following fix as well. params[2].type = ACPI_TYPE_INTEGER; --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -638,7 +638,7 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func,     params[0].type = ACPI_TYPE_BUFFER;   params[0].buffer.length = 16; - params[0].buffer.pointer = (u8 *)&guid; + params[0].buffer.pointer = (u8 *)guid;   params[1].type = ACPI_TYPE_INTEGER; params[1].integer.value = rev;