| Message ID | 1501847119-1914-1-git-send-email-petri.latvala@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks Petri, now I can run testlists again! > -----Original Message----- > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf > Of Petri Latvala > Sent: Friday, August 4, 2017 2:45 PM > To: intel-gfx@lists.freedesktop.org > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Subject: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name > format parameters > > Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used > engines to only the default engine, dropping the engine name from subtest > names, but left over the format parameter. > > Fixes: 37b06eb9b526 ("tests/kms_busy: Only test against one engine") > Signed-off-by: Petri Latvala <petri.latvala@intel.com> > CC: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > tests/kms_busy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_busy.c b/tests/kms_busy.c index 16ab891..dc00214 > 100644 > --- a/tests/kms_busy.c > +++ b/tests/kms_busy.c > @@ -342,7 +342,7 @@ igt_main > test_flip(&display, e->exec_id | > e->flags, n, false); > } > igt_subtest_f("basic-modeset-%s", > - e->name, > kmstest_pipe_name(n)) { > + kmstest_pipe_name(n)) { > > igt_require(gem_has_ring(display.drm_fd, > > e->exec_id | e->flags)); > > -- > 2.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com> > -----Original Message----- > From: Lofstedt, Marta > Sent: Friday, August 4, 2017 3:05 PM > To: 'Petri Latvala' <petri.latvala@intel.com>; intel-gfx@lists.freedesktop.org > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Subject: RE: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name > format parameters > > Thanks Petri, now I can run testlists again! > > > -----Original Message----- > > From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On > > Behalf Of Petri Latvala > > Sent: Friday, August 4, 2017 2:45 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Subject: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name > > format parameters > > > > Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used > > engines to only the default engine, dropping the engine name from > > subtest names, but left over the format parameter. > > > > Fixes: 37b06eb9b526 ("tests/kms_busy: Only test against one engine") > > Signed-off-by: Petri Latvala <petri.latvala@intel.com> > > CC: Daniel Vetter <daniel.vetter@ffwll.ch> > > --- > > tests/kms_busy.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/kms_busy.c b/tests/kms_busy.c index > > 16ab891..dc00214 > > 100644 > > --- a/tests/kms_busy.c > > +++ b/tests/kms_busy.c > > @@ -342,7 +342,7 @@ igt_main > > test_flip(&display, e->exec_id | > > e->flags, n, false); > > } > > igt_subtest_f("basic-modeset-%s", > > - e->name, > > kmstest_pipe_name(n)) { > > + kmstest_pipe_name(n)) { > > > > igt_require(gem_has_ring(display.drm_fd, > > > > e->exec_id | e->flags)); > > > > -- > > 2.9.3 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/tests/kms_busy.c b/tests/kms_busy.c index 16ab891..dc00214 100644 --- a/tests/kms_busy.c +++ b/tests/kms_busy.c @@ -342,7 +342,7 @@ igt_main test_flip(&display, e->exec_id | e->flags, n, false); } igt_subtest_f("basic-modeset-%s", - e->name, kmstest_pipe_name(n)) { + kmstest_pipe_name(n)) { igt_require(gem_has_ring(display.drm_fd, e->exec_id | e->flags));
Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used engines to only the default engine, dropping the engine name from subtest names, but left over the format parameter. Fixes: 37b06eb9b526 ("tests/kms_busy: Only test against one engine") Signed-off-by: Petri Latvala <petri.latvala@intel.com> CC: Daniel Vetter <daniel.vetter@ffwll.ch> --- tests/kms_busy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)