| Message ID | 1505279961-16140-1-git-send-email-shawn.c.lee@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 13 Sep 2017, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote: > Min brightness value from vbt was missing for CNP platform. > This setting have to refer backlight ic spec to restrict > min backlight output. Without this restriction, driver would > allow to configure lower brightness value and violate > backlight ic requirement. > > Fixes: 4c9f7086ac6d ("drm/i915/cnp: Backlight support for CNP.") > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Shawn Lee <shawn.c.lee@intel.com> Pushed, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/intel_panel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index d4dd248ac9a8..3b1c5d783ee7 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -1737,6 +1737,8 @@ cnp_setup_backlight(struct intel_connector *connector, enum pipe unused) > if (!panel->backlight.max) > return -ENODEV; > > + panel->backlight.min = get_backlight_min_vbt(connector); > + > val = bxt_get_backlight(connector); > val = intel_panel_compute_brightness(connector, val); > panel->backlight.level = clamp(val, panel->backlight.min,
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index d4dd248ac9a8..3b1c5d783ee7 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -1737,6 +1737,8 @@ cnp_setup_backlight(struct intel_connector *connector, enum pipe unused) if (!panel->backlight.max) return -ENODEV; + panel->backlight.min = get_backlight_min_vbt(connector); + val = bxt_get_backlight(connector); val = intel_panel_compute_brightness(connector, val); panel->backlight.level = clamp(val, panel->backlight.min,
Min brightness value from vbt was missing for CNP platform. This setting have to refer backlight ic spec to restrict min backlight output. Without this restriction, driver would allow to configure lower brightness value and violate backlight ic requirement. Fixes: 4c9f7086ac6d ("drm/i915/cnp: Backlight support for CNP.") Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Shawn Lee <shawn.c.lee@intel.com> --- drivers/gpu/drm/i915/intel_panel.c | 2 ++ 1 file changed, 2 insertions(+)