| Message ID | 1505917955-6623-1-git-send-email-vathsala.nagaraju@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: > Add defines for dpcd register 2009 (synchronization latency > in sink). > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > CC: Puthikorn Voravootivat <puthik@chromium.org> > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> > --- > include/drm/drm_dp_helper.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 11c39f1..846004e6 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -735,6 +735,9 @@ > # define DP_PSR_SINK_INTERNAL_ERROR 7 > # define DP_PSR_SINK_STATE_MASK 0x07 > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf where did you get that? eDP 1.4 teels 2009h is a debug register. > + > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) > > -- > 1.9.1 >
On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: > Add defines for dpcd register 2009 (synchronization latency > in sink). > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > CC: Puthikorn Voravootivat <puthik@chromium.org> > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> I keep forgetting to update my eDP spec 1.4 to this 1.4b... Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > include/drm/drm_dp_helper.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 11c39f1..846004e6 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -735,6 +735,9 @@ > # define DP_PSR_SINK_INTERNAL_ERROR 7 > # define DP_PSR_SINK_STATE_MASK 0x07 > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf > + > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) > > -- > 1.9.1 >
On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: > On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: > > Add defines for dpcd register 2009 (synchronization latency > > in sink). > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > CC: Puthikorn Voravootivat <puthik@chromium.org> > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> > > I keep forgetting to update my eDP spec 1.4 to this 1.4b... Maybe the patch should then make this clear, by annotating it with /* eDP 1.4b */ That's missing, which isn't all that great really, since it makes specs hunts like yours necessary. Please fix up before applying. -Daniel > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > > --- > > include/drm/drm_dp_helper.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > > index 11c39f1..846004e6 100644 > > --- a/include/drm/drm_dp_helper.h > > +++ b/include/drm/drm_dp_helper.h > > @@ -735,6 +735,9 @@ > > # define DP_PSR_SINK_INTERNAL_ERROR 7 > > # define DP_PSR_SINK_STATE_MASK 0x07 > > > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 > > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf > > + > > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ > > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) > > > > -- > > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter <daniel@ffwll.ch> wrote: > On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: > > On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: > > > Add defines for dpcd register 2009 (synchronization latency > > > in sink). > > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > CC: Puthikorn Voravootivat <puthik@chromium.org> > > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> > > > > I keep forgetting to update my eDP spec 1.4 to this 1.4b... > > Maybe the patch should then make this clear, by annotating it with > /* eDP 1.4b */ That's missing, which isn't all that great really, since it > makes specs hunts like yours necessary. > > It's actually in eDP 1.4 spec, table 5-6 page 86 > Please fix up before applying. > -Daniel > > > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > > > > > > --- > > > include/drm/drm_dp_helper.h | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > > > index 11c39f1..846004e6 100644 > > > --- a/include/drm/drm_dp_helper.h > > > +++ b/include/drm/drm_dp_helper.h > > > @@ -735,6 +735,9 @@ > > > # define DP_PSR_SINK_INTERNAL_ERROR 7 > > > # define DP_PSR_SINK_STATE_MASK 0x07 > > > > > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 > > > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf > > > + > > > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ > > > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) > > > > > > -- > > > 1.9.1 > > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch >
On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat < puthik@chromium.org> wrote: > > > On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter <daniel@ffwll.ch> wrote: > >> On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: >> > On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: >> > > Add defines for dpcd register 2009 (synchronization latency >> > > in sink). >> > > >> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> > > CC: Puthikorn Voravootivat <puthik@chromium.org> >> > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> >> > >> > I keep forgetting to update my eDP spec 1.4 to this 1.4b... >> >> Maybe the patch should then make this clear, by annotating it with >> /* eDP 1.4b */ That's missing, which isn't all that great really, since it >> makes specs hunts like yours necessary. >> >> It's actually in eDP 1.4 spec, table 5-6 page 86 > Copy and paste the wrong one. 0x2009 is actually in eDP 1.4 spec, Table 6-7: DPCD – Sink Device PSR Status Field page 124 > > >> Please fix up before applying. >> -Daniel >> > >> > >> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >> > >> > >> > >> > > --- >> > > include/drm/drm_dp_helper.h | 3 +++ >> > > 1 file changed, 3 insertions(+) >> > > >> > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h >> > > index 11c39f1..846004e6 100644 >> > > --- a/include/drm/drm_dp_helper.h >> > > +++ b/include/drm/drm_dp_helper.h >> > > @@ -735,6 +735,9 @@ >> > > # define DP_PSR_SINK_INTERNAL_ERROR 7 >> > > # define DP_PSR_SINK_STATE_MASK 0x07 >> > > >> > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 >> > > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf >> > > + >> > > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ >> > > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) >> > > >> > > -- >> > > 1.9.1 >> > > >> > _______________________________________________ >> > dri-devel mailing list >> > dri-devel@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> -- >> Daniel Vetter >> Software Engineer, Intel Corporation >> http://blog.ffwll.ch >> > >
On Tue, Sep 26, 2017 at 1:37 PM, Puthikorn Voravootivat <puthik@chromium.org> wrote: > > > On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat > <puthik@chromium.org> wrote: >> >> >> >> On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter <daniel@ffwll.ch> wrote: >>> >>> On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: >>> > On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: >>> > > Add defines for dpcd register 2009 (synchronization latency >>> > > in sink). >>> > > >>> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >>> > > CC: Puthikorn Voravootivat <puthik@chromium.org> >>> > > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> >>> > >>> > I keep forgetting to update my eDP spec 1.4 to this 1.4b... >>> >>> Maybe the patch should then make this clear, by annotating it with >>> /* eDP 1.4b */ That's missing, which isn't all that great really, since >>> it >>> makes specs hunts like yours necessary. >>> >> It's actually in eDP 1.4 spec, table 5-6 page 86 > > Copy and paste the wrong one. > 0x2009 is actually in eDP 1.4 spec, Table 6-7: DPCD – Sink Device PSR Status > Field page 124 you are absolutely right! eDP 1.4 has it. even the eDP 1.4a had... I definitely had a strange version here... All updated locally here. For the patch I will update when merging. No need to send a newer version. I intend to merge patches tomorrow if no one has any other comment or concern on those. > >> >> >>> >>> Please fix up before applying. >>> -Daniel >>> > >>> > >>> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >>> > >>> > >>> > >>> > > --- >>> > > include/drm/drm_dp_helper.h | 3 +++ >>> > > 1 file changed, 3 insertions(+) >>> > > >>> > > diff --git a/include/drm/drm_dp_helper.h >>> > > b/include/drm/drm_dp_helper.h >>> > > index 11c39f1..846004e6 100644 >>> > > --- a/include/drm/drm_dp_helper.h >>> > > +++ b/include/drm/drm_dp_helper.h >>> > > @@ -735,6 +735,9 @@ >>> > > # define DP_PSR_SINK_INTERNAL_ERROR 7 >>> > > # define DP_PSR_SINK_STATE_MASK 0x07 >>> > > >>> > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 >>> > > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf >>> > > + >>> > > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ >>> > > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) >>> > > >>> > > -- >>> > > 1.9.1 >>> > > >>> > _______________________________________________ >>> > dri-devel mailing list >>> > dri-devel@lists.freedesktop.org >>> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >>> >>> -- >>> Daniel Vetter >>> Software Engineer, Intel Corporation >>> http://blog.ffwll.ch >> >> > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 11c39f1..846004e6 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -735,6 +735,9 @@ # define DP_PSR_SINK_INTERNAL_ERROR 7 # define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf + #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
Add defines for dpcd register 2009 (synchronization latency in sink). Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> CC: Puthikorn Voravootivat <puthik@chromium.org> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com> --- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)