| Message ID | 1507015023-16524-2-git-send-email-madhav.chauhan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 03 Oct 2017, Madhav Chauhan <madhav.chauhan@intel.com> wrote: > This patch re-use already parsed DSI backlight/cabc ports > info for saving it inside struct intel_dsi rather than > parsing it at the time of DSI initialization. > > Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com> With the initialization of dl_dcs_backlight_ports and dl_dcs_cabc_ports removed, as mentioned in patch 1, this is Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/intel_dsi.c | 37 ++++--------------------------------- > 1 file changed, 4 insertions(+), 33 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c > index 20a7b00..6d21ae8 100644 > --- a/drivers/gpu/drm/i915/intel_dsi.c > +++ b/drivers/gpu/drm/i915/intel_dsi.c > @@ -1746,42 +1746,13 @@ void intel_dsi_init(struct drm_i915_private *dev_priv) > else > intel_encoder->crtc_mask = BIT(PIPE_B); > > - if (dev_priv->vbt.dsi.config->dual_link) { > + if (dev_priv->vbt.dsi.config->dual_link) > intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C); > - > - switch (dev_priv->vbt.dsi.config->dl_dcs_backlight_ports) { > - case DL_DCS_PORT_A: > - intel_dsi->dcs_backlight_ports = BIT(PORT_A); > - break; > - case DL_DCS_PORT_C: > - intel_dsi->dcs_backlight_ports = BIT(PORT_C); > - break; > - default: > - case DL_DCS_PORT_A_AND_C: > - intel_dsi->dcs_backlight_ports = BIT(PORT_A) | BIT(PORT_C); > - break; > - } > - > - switch (dev_priv->vbt.dsi.config->dl_dcs_cabc_ports) { > - case DL_DCS_PORT_A: > - intel_dsi->dcs_cabc_ports = BIT(PORT_A); > - break; > - case DL_DCS_PORT_C: > - intel_dsi->dcs_cabc_ports = BIT(PORT_C); > - break; > - default: > - case DL_DCS_PORT_A_AND_C: > - intel_dsi->dcs_cabc_ports = BIT(PORT_A) | BIT(PORT_C); > - break; > - } > - } else { > + else > intel_dsi->ports = BIT(port); > - intel_dsi->dcs_backlight_ports = BIT(port); > - intel_dsi->dcs_cabc_ports = BIT(port); > - } > > - if (!dev_priv->vbt.dsi.config->cabc_supported) > - intel_dsi->dcs_cabc_ports = 0; > + intel_dsi->dcs_backlight_ports = dev_priv->vbt.dsi.bl_ports; > + intel_dsi->dcs_cabc_ports = dev_priv->vbt.dsi.cabc_ports; > > /* Create a DSI host (and a device) for each port. */ > for_each_dsi_port(port, intel_dsi->ports) {
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 20a7b00..6d21ae8 100644 --- a/drivers/gpu/drm/i915/intel_dsi.c +++ b/drivers/gpu/drm/i915/intel_dsi.c @@ -1746,42 +1746,13 @@ void intel_dsi_init(struct drm_i915_private *dev_priv) else intel_encoder->crtc_mask = BIT(PIPE_B); - if (dev_priv->vbt.dsi.config->dual_link) { + if (dev_priv->vbt.dsi.config->dual_link) intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C); - - switch (dev_priv->vbt.dsi.config->dl_dcs_backlight_ports) { - case DL_DCS_PORT_A: - intel_dsi->dcs_backlight_ports = BIT(PORT_A); - break; - case DL_DCS_PORT_C: - intel_dsi->dcs_backlight_ports = BIT(PORT_C); - break; - default: - case DL_DCS_PORT_A_AND_C: - intel_dsi->dcs_backlight_ports = BIT(PORT_A) | BIT(PORT_C); - break; - } - - switch (dev_priv->vbt.dsi.config->dl_dcs_cabc_ports) { - case DL_DCS_PORT_A: - intel_dsi->dcs_cabc_ports = BIT(PORT_A); - break; - case DL_DCS_PORT_C: - intel_dsi->dcs_cabc_ports = BIT(PORT_C); - break; - default: - case DL_DCS_PORT_A_AND_C: - intel_dsi->dcs_cabc_ports = BIT(PORT_A) | BIT(PORT_C); - break; - } - } else { + else intel_dsi->ports = BIT(port); - intel_dsi->dcs_backlight_ports = BIT(port); - intel_dsi->dcs_cabc_ports = BIT(port); - } - if (!dev_priv->vbt.dsi.config->cabc_supported) - intel_dsi->dcs_cabc_ports = 0; + intel_dsi->dcs_backlight_ports = dev_priv->vbt.dsi.bl_ports; + intel_dsi->dcs_cabc_ports = dev_priv->vbt.dsi.cabc_ports; /* Create a DSI host (and a device) for each port. */ for_each_dsi_port(port, intel_dsi->ports) {
This patch re-use already parsed DSI backlight/cabc ports info for saving it inside struct intel_dsi rather than parsing it at the time of DSI initialization. Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com> --- drivers/gpu/drm/i915/intel_dsi.c | 37 ++++--------------------------------- 1 file changed, 4 insertions(+), 33 deletions(-)