diff mbox series

[6/6] drm/i915/icl: Update port clock in compute config

Message ID 1543311548-19149-7-git-send-email-vandita.kulkarni@intel.com (mailing list archive)
State New, archived
Headers show
Series ICL DSI PLL enable | expand

Commit Message

Kulkarni, Vandita Nov. 27, 2018, 9:39 a.m. UTC
For DSI 8X clock is AFE clock which is
is 5 times port clock.

Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
 drivers/gpu/drm/i915/icl_dsi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chauhan, Madhav Nov. 27, 2018, 11:20 a.m. UTC | #1
> -----Original Message-----
> From: Kulkarni, Vandita
> Sent: Tuesday, November 27, 2018 3:09 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Chauhan, Madhav <madhav.chauhan@intel.com>; Nikula, Jani
> <jani.nikula@intel.com>; Syrjala, Ville <ville.syrjala@intel.com>; Kulkarni,
> Vandita <vandita.kulkarni@intel.com>
> Subject: [PATCH 6/6] drm/i915/icl: Update port clock in compute config
> 
> For DSI 8X clock is AFE clock which is
> is 5 times port clock.

This description need to be rewritten atleast removal of "is" duplication.

> 
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
>  drivers/gpu/drm/i915/icl_dsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c
> index 80382fb..2812129 100644
> --- a/drivers/gpu/drm/i915/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/icl_dsi.c
> @@ -1183,6 +1183,7 @@ static bool gen11_dsi_compute_config(struct
> intel_encoder *encoder,
>  		pipe_config->cpu_transcoder = TRANSCODER_DSI_0;
> 
>  	pipe_config->clock_set = true;
> +	pipe_config->port_clock = intel_dsi_bitrate(intel_dsi)/5;
> 
>  	//TODO: Add check if DSI PLL calculation is done

We won't need this "TODO" now.

With these fixes,
Reviewed-by: Madhav Chauhan <madhav.chauhan@intel.com>

Regards,
Madhav

> 
> --
> 1.9.1
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c
index 80382fb..2812129 100644
--- a/drivers/gpu/drm/i915/icl_dsi.c
+++ b/drivers/gpu/drm/i915/icl_dsi.c
@@ -1183,6 +1183,7 @@  static bool gen11_dsi_compute_config(struct intel_encoder *encoder,
 		pipe_config->cpu_transcoder = TRANSCODER_DSI_0;
 
 	pipe_config->clock_set = true;
+	pipe_config->port_clock = intel_dsi_bitrate(intel_dsi)/5;
 
 	//TODO: Add check if DSI PLL calculation is done