From patchwork Wed Aug 19 20:28:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Bruno_Pr=C3=A9mont?= X-Patchwork-Id: 42778 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7JKb3IK011572 for ; Wed, 19 Aug 2009 20:37:03 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 984939E7F0; Wed, 19 Aug 2009 13:37:02 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org X-Greylist: delayed 472 seconds by postgrey-1.30 at gabe; Wed, 19 Aug 2009 13:37:00 PDT Received: from bonbons.gotdns.org (ppp-145-186.adsl.restena.lu [158.64.145.186]) by gabe.freedesktop.org (Postfix) with ESMTP id 492919E7E1 for ; Wed, 19 Aug 2009 13:37:00 -0700 (PDT) Received: from neptune.home (neptune.home [IPv6:2001:960:7ab:0:2c0:9fff:fe2d:39d]) by smtp.home (Postfix) with ESMTP id E6B1A450AE; Wed, 19 Aug 2009 22:29:06 +0200 (CEST) Date: Wed, 19 Aug 2009 22:28:43 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Eric Anholt Message-ID: <20090819222843.0a3bce4e@neptune.home> In-Reply-To: <20090808130117.454a2649@neptune.home> References: <20090808130117.454a2649@neptune.home> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; i686-pc-linux-gnu) Mime-Version: 1.0 Cc: Ma Ling , intel-gfx@lists.freedesktop.org, dri-devel@lists.sourceforge.net Subject: [Intel-gfx] [PATCH resend] drm/i915: Add support for dual-channel LVDS on 8xx. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org drm/i915: Check if BIOS enabled dual-channel LVDS on 8xx, not only on 9xx Commit 0c2e39525b3b53a97a0202c5f35058147e53977e is not sufficient to get fd.o bug #20115 fixed. In addition intel_find_best_PLL() must not only rely on BIOS settings for i9xx chips but also for i8xx, so drop the IS_I9XX() check. Signed-off-by: Bruno Prémont Acked-by: Zhao Yakui --- Hi Eric, Ma Ling, http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0c2e39525b3b53a97a0202c5f35058147e53977e (drm/i915: Add support for dual-channel LVDS on 8xx.) is not sufficient for i8xx, below patch is needed too for LVDS to work on my Acer TM66x. In case this is not appropriate for newer chips replacing IS_I9XX(dev) with (IS_I9XX(dev) || IS_I85X(dev)) would be sufficient for me though other i8xx variants would possibly need to be added too/later on. Bruno -- current diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index d6fce21..486bdaf 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -666,7 +666,7 @@ intel_find_best_PLL(const intel_limit_t *limit, struct drm_crtc *crtc, intel_clock_t clock; int err = target; - if (IS_I9XX(dev) && intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) && + if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) && (I915_READ(LVDS)) != 0) { /* * For LVDS, if the panel is on, just rely on its