From patchwork Wed Sep 16 07:33:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhenyu Wang X-Patchwork-Id: 47841 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8G7XZoa029954 for ; Wed, 16 Sep 2009 07:33:35 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D9759E97F; Wed, 16 Sep 2009 00:33:34 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fmsmga102.fm.intel.com (mga10.intel.com [192.55.52.92]) by gabe.freedesktop.org (Postfix) with ESMTP id 439DB9E79C for ; Wed, 16 Sep 2009 00:33:31 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 16 Sep 2009 00:21:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,396,1249282800"; d="asc'?scan'208";a="727379132" Received: from zhen-devel.sh.intel.com (HELO zhen-devel) ([10.239.13.150]) by fmsmga001.fm.intel.com with ESMTP; 16 Sep 2009 00:36:30 -0700 Date: Wed, 16 Sep 2009 15:33:30 +0800 From: Zhenyu Wang To: Keith Packard Message-ID: <20090916073330.GA11635@zhen-devel.sh.intel.com> Mail-Followup-To: Keith Packard , "Jin, Gordon" , "intel-gfx@lists.freedesktop.org" References: <1251903453-12710-1-git-send-email-zhenyuw@linux.intel.com> <20090915022607.GF5512@zhen-devel.sh.intel.com> <10C63FAD690C13458F0B32BCED571F140270B1C3E2@pdsmsx502.ccr.corp.intel.com> <20090915071405.GA2880@zhen-devel.sh.intel.com> <1253027501.17459.21.camel@aiko.keithp.com> MIME-Version: 1.0 In-Reply-To: <1253027501.17459.21.camel@aiko.keithp.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "intel-gfx@lists.freedesktop.org" Subject: Re: [Intel-gfx] [PATCH] Make DGA optional X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.9 Precedence: list Reply-To: Zhenyu Wang List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org On 2009.09.15 08:11:41 -0700, Keith Packard wrote: > On Tue, 2009-09-15 at 15:14 +0800, Zhenyu Wang wrote: > > > As DGA is optional in xserver, revert that one might crash X in start. > > Or we just fake to init DGA proto, not sure if there's any DGA callbacks > > that driver can use for framebuffer open later? > > DGA isn't really optional; you'd have to recompile the X server to > disable it. And, as we know, many applications depend on it (but only > for input). > Keith, are you ok with this one? From 0449c374fd114d392412793e57cfdd8cefb7a504 Mon Sep 17 00:00:00 2001 From: Zhenyu Wang Date: Wed, 16 Sep 2009 15:28:22 +0800 Subject: [PATCH] Always enable DGA Partially revert fe7693c94a396b9d17bb66a000178750a432ce3a, which did DGA disable in KMS case, which causes problem for games require DGA for mouse tracking. So in KMS, we'll pass '-1' address for DGA which is fine as nobody should use DGA for rendering now. oh, well. Signed-off-by: Zhenyu Wang --- src/i830_driver.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/i830_driver.c b/src/i830_driver.c index e3e1ed2..5585df0 100644 --- a/src/i830_driver.c +++ b/src/i830_driver.c @@ -2739,8 +2739,7 @@ I830ScreenInit(int scrnIndex, ScreenPtr pScreen, int argc, char **argv) xf86SetBlackWhitePixels(pScreen); #ifdef XFreeXDGA - if (!pI830->use_drm_mode) - xf86DiDGAInit (pScreen, pI830->LinearAddr + pScrn->fbOffset); + xf86DiDGAInit (pScreen, pI830->LinearAddr + pScrn->fbOffset); #endif if (!I830AccelInit(pScreen)) {