From patchwork Fri Nov 28 15:39:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lespiau, Damien" X-Patchwork-Id: 5404361 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9D21C9F47A for ; Fri, 28 Nov 2014 15:39:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AE748201B4 for ; Fri, 28 Nov 2014 15:39:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id BA54E201BB for ; Fri, 28 Nov 2014 15:39:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 231016E400; Fri, 28 Nov 2014 07:39:33 -0800 (PST) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F2036E400 for ; Fri, 28 Nov 2014 07:39:31 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 28 Nov 2014 07:32:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="422701410" Received: from unknown (HELO strange.ger.corp.intel.com) ([10.252.14.228]) by FMSMGA003.fm.intel.com with ESMTP; 28 Nov 2014 07:29:33 -0800 Date: Fri, 28 Nov 2014 15:39:29 +0000 From: Damien Lespiau To: tim.gore@intel.com Message-ID: <20141128153929.GB8425@strange.ger.corp.intel.com> References: <1417185984-30815-1-git-send-email-tim.gore@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1417185984-30815-1-git-send-email-tim.gore@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RFC] tests/gem_ring_sync_copy: reduce memory usage X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Nov 28, 2014 at 02:46:24PM +0000, tim.gore@intel.com wrote: > From: Tim Gore > > gem_ring_sync_copy uses a lot of memory and gets OOM > killed on smaller systems (eg android devices). > Most of the allocation is for "busy work" to keep the > render rings busy and for this we can just re-use the > same few buffers over and over. This enables the test > to be run on low end devices. > > Signed-off-by: Tim Gore The one thing I'm wondering is how we can ensure that 32 is indeed enough to create a dependency between the two rings. I'm not sure why you've chosen to remove n_buffers_load (without actually removing it from the test data. How about: diff --git a/tests/gem_ring_sync_copy.c b/tests/gem_ring_sync_copy.c index 4a732d2..2561bac 100644 --- a/tests/gem_ring_sync_copy.c +++ b/tests/gem_ring_sync_copy.c @@ -331,7 +331,7 @@ igt_main data.drm_fd = drm_open_any_render(); data.devid = intel_get_drm_devid(data.drm_fd); - data.n_buffers_load = 1000; + data.n_buffers_load = 32; data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096); igt_assert(data.bufmgr);