diff mbox

[i-g-t,1/2] aubdump: remove already handled -o

Message ID 20161005224827.14000-1-lionel.g.landwerlin@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lionel Landwerlin Oct. 5, 2016, 10:48 p.m. UTC 
From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
Cc: Sirisha Gandikota <Sirisha.Gandikota@intel.com>
---
 tools/intel_aubdump.in | 4 ----
 1 file changed, 4 deletions(-)

Comments

Petri Latvala Oct. 6, 2016, 9:09 a.m. UTC | #1 
On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote:
> -	  -o*)
> -	      file=${1##-o}
> -	      shift
> -	      ;;


This breaks using -ofilename without spaces.


--
Petri Latvala
Lionel Landwerlin Oct. 6, 2016, 9:16 a.m. UTC | #2 
On 06/10/16 10:09, Petri Latvala wrote:
> On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote:
>> -	  -o*)
>> -	      file=${1##-o}
>> -	      shift
>> -	      ;;
>
> This breaks using -ofilename without spaces.
>
>

Oh right, I didn't realize that was an acceptable input.
Let's drop this patch then.

Thanks!

-
Lionel
diff mbox

Patch

diff --git a/tools/intel_aubdump.in b/tools/intel_aubdump.in
index feee23a..3666b6e 100644
--- a/tools/intel_aubdump.in
+++ b/tools/intel_aubdump.in
@@ -34,10 +34,6 @@  while true; do
 	      verbose=1
 	      shift 1
 	      ;;
-	  -o*)
-	      file=${1##-o}
-	      shift
-	      ;;
 	  --output=*)
 	      file=${1##--output=}
 	      shift