From patchwork Mon Jan 30 15:12:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 9545589 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7C02604A8 for ; Mon, 30 Jan 2017 15:12:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA49A27F07 for ; Mon, 30 Jan 2017 15:12:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEED628159; Mon, 30 Jan 2017 15:12:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1F15127F07 for ; Mon, 30 Jan 2017 15:12:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E008892E0; Mon, 30 Jan 2017 15:12:38 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69CE0892E0 for ; Mon, 30 Jan 2017 15:12:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: robertfoss) with ESMTPSA id 366ED26786F From: Robert Foss To: intel-gfx@lists.freedesktop.org, Tomeu Vizoso , Maarten Lankhorst , Daniel Stone , Mika Kahola , Petri Latvala , Eric Engestrom Date: Mon, 30 Jan 2017 10:12:28 -0500 Message-Id: <20170130151228.27886-1-robert.foss@collabora.com> X-Mailer: git-send-email 2.11.0.453.g787f75f05 Subject: [Intel-gfx] [PATCH i-g-t v1] lib/drmtest: Add comment explaining DRIVER_ANY excluding DRIVER_VGEM X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- lib/drmtest.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/drmtest.h b/lib/drmtest.h index 19d4bd19..c9c019c0 100644 --- a/lib/drmtest.h +++ b/lib/drmtest.h @@ -42,8 +42,15 @@ #define DRIVER_VC4 (1 << 1) #define DRIVER_VGEM (1 << 2) #define DRIVER_VIRTIO (1 << 3) +/* + * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system + * with vgem as well as a supported driver, you can end up with a + * near-100% skip rate if you don't explicitly specify the device, + * depending on device-load ordering. + */ #define DRIVER_ANY ~(DRIVER_VGEM) + #ifdef ANDROID #if (!(defined HAVE_MMAP64)) && (!(defined __x86_64__)) extern void* __mmap2(void *, size_t, int, int, int, off_t);