| Message ID | 20170222125928.30223-1-ander.conselvan.de.oliveira@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
At the first glace, I thought LSPCON is type2 HDMI only, then I realized not really for us (:-)) Reviewed-by: Shashank Sharma Regards Shashank On 2/22/2017 6:29 PM, Ander Conselvan de Oliveira wrote: > Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(), > otherwise a call to that function can theoretically trigger a WARN. > > Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") > Cc: Shashank Sharma <shashank.sharma@intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Dave Airlie <airlied@gmail.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> > --- > drivers/gpu/drm/drm_dp_dual_mode_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c > index e025639..80e62f6 100644 > --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c > +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c > @@ -386,6 +386,8 @@ const char *drm_dp_get_dual_mode_type_name(enum drm_dp_dual_mode_type type) > return "type 2 DVI"; > case DRM_DP_DUAL_MODE_TYPE2_HDMI: > return "type 2 HDMI"; > + case DRM_DP_DUAL_MODE_LSPCON: > + return "lspcon"; > default: > WARN_ON(type != DRM_DP_DUAL_MODE_UNKNOWN); > return "unknown";
On Wed, Feb 22, 2017 at 02:59:28PM +0200, Ander Conselvan de Oliveira wrote: > Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(), > otherwise a call to that function can theoretically trigger a WARN. > > Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") > Cc: Shashank Sharma <shashank.sharma@intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Dave Airlie <airlied@gmail.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Applied to -misc Thanks, Sean > --- > drivers/gpu/drm/drm_dp_dual_mode_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c > index e025639..80e62f6 100644 > --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c > +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c > @@ -386,6 +386,8 @@ const char *drm_dp_get_dual_mode_type_name(enum drm_dp_dual_mode_type type) > return "type 2 DVI"; > case DRM_DP_DUAL_MODE_TYPE2_HDMI: > return "type 2 HDMI"; > + case DRM_DP_DUAL_MODE_LSPCON: > + return "lspcon"; > default: > WARN_ON(type != DRM_DP_DUAL_MODE_UNKNOWN); > return "unknown"; > -- > 2.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_dp_dual_mode_helper.c b/drivers/gpu/drm/drm_dp_dual_mode_helper.c index e025639..80e62f6 100644 --- a/drivers/gpu/drm/drm_dp_dual_mode_helper.c +++ b/drivers/gpu/drm/drm_dp_dual_mode_helper.c @@ -386,6 +386,8 @@ const char *drm_dp_get_dual_mode_type_name(enum drm_dp_dual_mode_type type) return "type 2 DVI"; case DRM_DP_DUAL_MODE_TYPE2_HDMI: return "type 2 HDMI"; + case DRM_DP_DUAL_MODE_LSPCON: + return "lspcon"; default: WARN_ON(type != DRM_DP_DUAL_MODE_UNKNOWN); return "unknown";
Handle DRM_DP_DUAL_MODE_LSPCON in drm_dp_get_dual_mode_type_name(), otherwise a call to that function can theoretically trigger a WARN. Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") Cc: Shashank Sharma <shashank.sharma@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Dave Airlie <airlied@gmail.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Sean Paul <seanpaul@chromium.org> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> --- drivers/gpu/drm/drm_dp_dual_mode_helper.c | 2 ++ 1 file changed, 2 insertions(+)