From patchwork Wed Feb 22 15:25:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Bragg X-Patchwork-Id: 9587009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 26CE06020B for ; Wed, 22 Feb 2017 15:25:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F3EF28650 for ; Wed, 22 Feb 2017 15:25:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 140FC2865A; Wed, 22 Feb 2017 15:25:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2AE7728650 for ; Wed, 22 Feb 2017 15:25:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 992EA6E839; Wed, 22 Feb 2017 15:25:32 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C2CC6E839 for ; Wed, 22 Feb 2017 15:25:31 +0000 (UTC) Received: by mail-wr0-x244.google.com with SMTP id z61so777971wrc.3 for ; Wed, 22 Feb 2017 07:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ucKdOM0I95LpB8lgoADW7b6KMfxieKJJaufnKm8uFLM=; b=fL8IZ5XKe9a1lmsroMZmbtBL/PPsq+MbQ5YKVSSpYIP9XL5boHYD7ygTxmfScyv1Zy zorlqztTT6KLOpBiVfEqk/5ncHeJYzfDjisAdYCjfRmcRC7z6zDu21fQv5XwLlH3CDBs zLVrvRGDudHQ+CTxVxmxuLByoZDog7QHtdIq7d/ncL2O9PlOW9aFIjt/XnBff2MeIE1U wqew9pvyJqzBqtbC1SNrYRq7tWoI1iPWIavsTFZ4ZdmG+jDBvQ1nuE5Bg8Jm5DKDXy4Y xImArSrSMj5yHY9rhjUYIe5jtCUhZ3EzNwH2dMu5VGYb6YL/6JXwKrJf8Xl0lihTlxpa QUPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ucKdOM0I95LpB8lgoADW7b6KMfxieKJJaufnKm8uFLM=; b=MHZUS7lJWhAG7fDUj+nptzNP/e6whluU19SyDACrhdAszKjpTM6pyLsHgOc9p9mlaG 6hoB2QSO8epv31+x4B5f9n9mzODPuBxRke712e3GTtpetcDnZPr9EVx4oFNAI1D90wox ADkM/NzjaEbltQCWkUShhEFK8AIxTVrbVVdw5/VXlkVzcF3clnrchyHYxeCKTVSDuU+z Z2YIvogd9bqvJsPLczRT4CKMpHTXr8+sZK0v9OsSQ1hsbDHk1E941d2jvgKI+TI8MjbA 8b3U7qCHsrOv+eYhA3Qve4FIqkCR+9AEp2/pzpfBXA4ekeOc26qs6I4s/ScEgycti5GY jP9g== X-Gm-Message-State: AMke39mMadzHlPt49jO87E7ZOrEOJQkrwbaE2V1ZyYFSsStEVNu+6uZjOAuOT9EbcriLKg== X-Received: by 10.223.179.15 with SMTP id j15mr23514639wrd.159.1487777130024; Wed, 22 Feb 2017 07:25:30 -0800 (PST) Received: from sixbynine.org (cpc26-heme10-2-0-cust305.9-1.cable.virginm.net. [86.3.57.50]) by smtp.gmail.com with ESMTPSA id r6sm2493293wmd.4.2017.02.22.07.25.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Feb 2017 07:25:29 -0800 (PST) From: Robert Bragg To: intel-gfx@lists.freedesktop.org Date: Wed, 22 Feb 2017 15:25:08 +0000 Message-Id: <20170222152510.5039-2-robert@sixbynine.org> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170222152510.5039-1-robert@sixbynine.org> References: <20170222152510.5039-1-robert@sixbynine.org> Subject: [Intel-gfx] [PATCH 1/3] drm/i915/perf: improve invalid OA format debug message X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP A minor improvement to debugging output Signed-off-by: Robert Bragg Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 383b5769a851..19d0e4222974 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -1898,11 +1898,13 @@ static int read_properties_unlocked(struct drm_i915_private *dev_priv, break; case DRM_I915_PERF_PROP_OA_FORMAT: if (value == 0 || value >= I915_OA_FORMAT_MAX) { - DRM_DEBUG("Invalid OA report format\n"); + DRM_DEBUG("Out-of-range OA report format %llu\n", + value); return -EINVAL; } if (!dev_priv->perf.oa.oa_formats[value].size) { - DRM_DEBUG("Invalid OA report format\n"); + DRM_DEBUG("Unsupported OA report format %llu\n", + value); return -EINVAL; } props->oa_format = value;