diff mbox

[maintainer-tools,3/3] dim.rst: update CONTRIBUTING instructions

Message ID 20170405111525.32602-3-eric.engestrom@imgtec.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Engestrom April 5, 2017, 11:15 a.m. UTC
Suggest using git-config instead of a flag on format-patch.
While at it, use the more common "PATCH foo" subject prefix.

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 dim.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Jani Nikula April 5, 2017, 11:25 a.m. UTC | #1
On Wed, 05 Apr 2017, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Suggest using git-config instead of a flag on format-patch.
> While at it, use the more common "PATCH foo" subject prefix.

More common? That's all so subjective.

And I've mostly used [dim PATCH]...

BR,
Jani.

>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  dim.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dim.rst b/dim.rst
> index b99248e..c650317 100644
> --- a/dim.rst
> +++ b/dim.rst
> @@ -476,10 +476,11 @@ CONTRIBUTING
>  ============
>  
>  Submit patches for any of the maintainer tools to the
> -intel-gfx@lists.freedesktop.org mailing list with [maintainer-tools PATCH]
> +intel-gfx@lists.freedesktop.org mailing list with [PATCH maintainer-tools]
>  prefix. Use::
>  
> -  $ git format-patch --subject-prefix="maintainer-tools PATCH"
> +  $ git config sendemail.to intel-gfx@lists.freedesktop.org
> +  $ git config format.subjectprefix 'PATCH maintainer-tools'
>  
>  for that. Please make sure your patches pass the build and self tests by
>  running::
Daniel Vetter April 5, 2017, 12:12 p.m. UTC | #2
On Wed, Apr 05, 2017 at 12:15:25PM +0100, Eric Engestrom wrote:
> Suggest using git-config instead of a flag on format-patch.
> While at it, use the more common "PATCH foo" subject prefix.
> 
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  dim.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/dim.rst b/dim.rst
> index b99248e..c650317 100644
> --- a/dim.rst
> +++ b/dim.rst
> @@ -476,10 +476,11 @@ CONTRIBUTING
>  ============
>  
>  Submit patches for any of the maintainer tools to the
> -intel-gfx@lists.freedesktop.org mailing list with [maintainer-tools PATCH]
> +intel-gfx@lists.freedesktop.org mailing list with [PATCH maintainer-tools]
>  prefix. Use::
>  
> -  $ git format-patch --subject-prefix="maintainer-tools PATCH"
> +  $ git config sendemail.to intel-gfx@lists.freedesktop.org
> +  $ git config format.subjectprefix 'PATCH maintainer-tools'

With dim this is a worktree checkout, which means all kernel patches end
up looking like this. Can we make this branch-specific?
-Daniel

>  
>  for that. Please make sure your patches pass the build and self tests by
>  running::
> -- 
> Cheers,
>   Eric
>
diff mbox

Patch

diff --git a/dim.rst b/dim.rst
index b99248e..c650317 100644
--- a/dim.rst
+++ b/dim.rst
@@ -476,10 +476,11 @@  CONTRIBUTING
 ============
 
 Submit patches for any of the maintainer tools to the
-intel-gfx@lists.freedesktop.org mailing list with [maintainer-tools PATCH]
+intel-gfx@lists.freedesktop.org mailing list with [PATCH maintainer-tools]
 prefix. Use::
 
-  $ git format-patch --subject-prefix="maintainer-tools PATCH"
+  $ git config sendemail.to intel-gfx@lists.freedesktop.org
+  $ git config format.subjectprefix 'PATCH maintainer-tools'
 
 for that. Please make sure your patches pass the build and self tests by
 running::