From patchwork Wed Apr 12 15:55:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Bragg X-Patchwork-Id: 9677679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4788C60383 for ; Wed, 12 Apr 2017 15:56:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AC9328592 for ; Wed, 12 Apr 2017 15:56:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F12F28627; Wed, 12 Apr 2017 15:56:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F0F4F28592 for ; Wed, 12 Apr 2017 15:56:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8ECC289700; Wed, 12 Apr 2017 15:56:28 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B02C89700 for ; Wed, 12 Apr 2017 15:56:26 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id q125so7302023wmd.3 for ; Wed, 12 Apr 2017 08:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=V27QjkN1itNvPuUiP72Bt0pYDYXWUPTVt10FkYOVIsc=; b=JRxqkf52biwiz+8ZrPAl2ogWAPbX7MJh1mWeVs3ypQYMyYZ25x8CkRR9g0PnUHz0au CZwj6yaX/EbQJoEP0WBFCPOMkMhZ7xVATPQrG6sXTsTrQdv96taaTU5K7S+Yz2cYk8J5 CS4niloBeQy0T08JpJVsdI3zLlj2NFolPDAbJi2iUtZqYtOx9QIRKTi+yYo7J1LkY6H5 cdAg+LCyO0xbDeEoTsMZ7d4f3WzbolUHysgKv0y5WjPUyf+hpUWdp0qdenXEB+7kF16r 11/uhrOzkFNt1c1yXrGvsEY+zU9SWe1wEXyUP/HOH1PmUFUABWJ/qm8a2varccGayx2c x4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=V27QjkN1itNvPuUiP72Bt0pYDYXWUPTVt10FkYOVIsc=; b=FrMWogJ2qACdh6mgTZCLKZ8yyER0ZOYT716toPvuUT6MyJlsEsjc5R4LDbF/nKLqiY GCxW8cY26QT1r6IPWiFeDmix6oOMkGCeFJ4J3lEG1v988gFhY9dSr6EaADXWuoL6OnZL UQRW08EQ3uVQrTSiy2Zbe3ZVPOl3c2HdjsQ2t6hz85Tk8+oQQAayTCsPAQpK0UpIONyu DRwtZIwRrb/rcEt70qmhx+yE4VjpLoD8V4UJG7NTdklpasdjp9sZyUSKAu0xSj2JAhgz rq8E0hGNlxJc9jiMM5TP2ZfVezQkR/lYgbqpeNSwIZRY9X/HaeVYbDJU9hwCRpisvzNe iobg== X-Gm-Message-State: AN3rC/6RaguY6esE8J67CLpPM1a6mLNjc6mhi4pJSKQ5bcooyfXSsw2p Juj0tnz6gxvatrxwgPU= X-Received: by 10.28.230.84 with SMTP id d81mr20468568wmh.117.1492012584725; Wed, 12 Apr 2017 08:56:24 -0700 (PDT) Received: from sixbynine.org (host-78-151-16-127.as13285.net. [78.151.16.127]) by smtp.gmail.com with ESMTPSA id 13sm7058685wml.25.2017.04.12.08.56.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Apr 2017 08:56:24 -0700 (PDT) From: Robert Bragg To: intel-gfx@lists.freedesktop.org Date: Wed, 12 Apr 2017 16:55:47 +0100 Message-Id: <20170412155556.6602-7-robert@sixbynine.org> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170412155556.6602-1-robert@sixbynine.org> References: <20170412155556.6602-1-robert@sixbynine.org> Subject: [Intel-gfx] [PATCH v4 06/15] drm/i915/perf: improve invalid OA format debug message X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP A minor improvement to debugging output Signed-off-by: Robert Bragg Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 18734e1926b9..08cc2b0dd734 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -1904,11 +1904,13 @@ static int read_properties_unlocked(struct drm_i915_private *dev_priv, break; case DRM_I915_PERF_PROP_OA_FORMAT: if (value == 0 || value >= I915_OA_FORMAT_MAX) { - DRM_DEBUG("Invalid OA report format\n"); + DRM_DEBUG("Out-of-range OA report format %llu\n", + value); return -EINVAL; } if (!dev_priv->perf.oa.oa_formats[value].size) { - DRM_DEBUG("Invalid OA report format\n"); + DRM_DEBUG("Unsupported OA report format %llu\n", + value); return -EINVAL; } props->oa_format = value;