[CI,v2,1/3] drm/i915: Remove misleading comment in request_alloc

Commit Message

Michał Winiarski May 23, 2017, 10:23 a.m. UTC

Passing NULL ctx to request_alloc would lead to null-ptr-deref.

v2: Let's not replace the comment with a BUG_ON

Signed-off-by: Michał Winiarski <[e-mail]>
Reviewed-by: Chris Wilson <[e-mail]>
---
 drivers/gpu/drm/i915/i915_gem_request.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Chris Wilson May 23, 2017, 10:49 a.m. UTC | #1

On Tue, May 23, 2017 at 10:42:04AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [CI,v2,1/3] drm/i915: Remove misleading comment in request_alloc
> URL   : https://patchwork.freedesktop.org/series/24822/
> State : failure
> 
> == Summary ==
> 
> Series 24822v1 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/24822/revisions/1/mbox/
> 
> Test gem_exec_flush:
>         Subgroup basic-batch-kernel-default-uc:
>                 pass       -> FAIL       (fi-snb-2600) fdo#100007
> Test kms_flip:
>         Subgroup basic-flip-vs-dpms:
>                 dmesg-warn -> DMESG-FAIL (fi-skl-6700hq) fdo#101144
>         Subgroup basic-flip-vs-modeset:
>                 pass       -> SKIP       (fi-skl-6700hq) fdo#100867
>         Subgroup basic-flip-vs-wf_vblank:
>                 pass       -> SKIP       (fi-skl-6700hq) fdo#99739
>         Subgroup basic-plain-flip:
>                 pass       -> SKIP       (fi-skl-6700hq)

...
As scary as they are, they are not the result of this patch.
Someone needs to give fi-skl-6700hq a cup of tea and tell it to calm
down.
-Chris

Chris Wilson May 23, 2017, 10:56 a.m. UTC | #2

On Tue, May 23, 2017 at 11:49:39AM +0100, Chris Wilson wrote:
> On Tue, May 23, 2017 at 10:42:04AM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [CI,v2,1/3] drm/i915: Remove misleading comment in request_alloc
> > URL   : https://patchwork.freedesktop.org/series/24822/
> > State : failure
> > 
> > == Summary ==
> > 
> > Series 24822v1 Series without cover letter
> > https://patchwork.freedesktop.org/api/1.0/series/24822/revisions/1/mbox/
> > 
> > Test gem_exec_flush:
> >         Subgroup basic-batch-kernel-default-uc:
> >                 pass       -> FAIL       (fi-snb-2600) fdo#100007
> > Test kms_flip:
> >         Subgroup basic-flip-vs-dpms:
> >                 dmesg-warn -> DMESG-FAIL (fi-skl-6700hq) fdo#101144
> >         Subgroup basic-flip-vs-modeset:
> >                 pass       -> SKIP       (fi-skl-6700hq) fdo#100867
> >         Subgroup basic-flip-vs-wf_vblank:
> >                 pass       -> SKIP       (fi-skl-6700hq) fdo#99739
> >         Subgroup basic-plain-flip:
> >                 pass       -> SKIP       (fi-skl-6700hq)
> 
> ...
> As scary as they are, they are not the result of this patch.
> Someone needs to give fi-skl-6700hq a cup of tea and tell it to calm
> down.

And pushed to repair GuC after my breakage. Thanks for the fix,
-Chris

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 1ccf252..0d1e0d8 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -538,9 +538,6 @@  submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)
  *
  * @engine: engine that we wish to issue the request on.
  * @ctx: context that the request will be associated with.
- *       This can be NULL if the request is not directly related to
- *       any specific user context, in which case this function will
- *       choose an appropriate context to use.
  *
  * Returns a pointer to the allocated request if successful,
  * or an error code if not.