From patchwork Wed Jun 14 18:15:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Wajdeczko X-Patchwork-Id: 9787219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E38AD60325 for ; Wed, 14 Jun 2017 18:16:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3F1D203C0 for ; Wed, 14 Jun 2017 18:16:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5ABD2848D; Wed, 14 Jun 2017 18:16:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 67ECA203C0 for ; Wed, 14 Jun 2017 18:16:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68C9C6E5C5; Wed, 14 Jun 2017 18:16:10 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACBB189F06 for ; Wed, 14 Jun 2017 18:16:09 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2017 11:16:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,341,1493708400"; d="scan'208";a="99513357" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 14 Jun 2017 11:16:08 -0700 Received: from mwajdecz-MOBL1.ger.corp.intel.com (mwajdecz-mobl1.ger.corp.intel.com [172.28.174.25]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id v5EIFv8q020077; Wed, 14 Jun 2017 19:16:07 +0100 From: Michal Wajdeczko To: intel-gfx@lists.freedesktop.org Date: Wed, 14 Jun 2017 18:15:51 +0000 Message-Id: <20170614181551.47136-5-michal.wajdeczko@intel.com> X-Mailer: git-send-email 2.10.1.windows.1 In-Reply-To: <20170614181551.47136-1-michal.wajdeczko@intel.com> References: <20170614181551.47136-1-michal.wajdeczko@intel.com> Subject: [Intel-gfx] [PATCH v3 4/4] drm/i915/debugfs: Highlight modified i915 params X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP We know default values for all params and we know which params are safe to change. Mark params that were changed when dumping them in debugfs. v2: simplify is_default calculation for strings (Chris) v3: rebased and switched into custom seq_print macros (Michal) Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Reviewed-by: Lukasz Fiedorowicz #2 --- drivers/gpu/drm/i915/i915_debugfs.c | 38 +++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 9fbba1e..bb71ff4 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -35,21 +35,21 @@ static inline struct drm_i915_private *node_to_i915(struct drm_info_node *node) return to_i915(node->minor->dev); } -static __always_inline void seq_print_param(struct seq_file *m, - const char *name, - const char *type, - const void *x) -{ - if (!__builtin_strcmp(type, "bool")) - seq_printf(m, "i915.%s=%s\n", name, yesno(*(const bool *)x)); - else if (!__builtin_strcmp(type, "int")) - seq_printf(m, "i915.%s=%d\n", name, *(const int *)x); - else if (!__builtin_strcmp(type, "uint")) - seq_printf(m, "i915.%s=%u\n", name, *(const unsigned int *)x); - else if (!__builtin_strcmp(type, "charp")) - seq_printf(m, "i915.%s=%s\n", name, *(const char **)x); - else - BUILD_BUG(); +#define seq_print_param_bool(m, name, x, tags) \ + seq_printf(m, "i915.%s=%s%s\n", name, yesno(x), tags) +#define seq_print_param_int(m, name, x, tags) \ + seq_printf(m, "i915.%s=%d%s\n", name, x, tags) +#define seq_print_param_uint(m, name, x, tags) \ + seq_printf(m, "i915.%s=%u%s\n", name, x, tags) +#define seq_print_param_charp(m, name, x, tags) \ + seq_printf(m, "i915.%s=%s%s\n", name, x, tags) + +static inline const char *param_tags(bool is_default, bool is_unsafe) +{ + if (is_default) + return ""; + + return is_unsafe ? " [modified *unsafe*]": " [modified]"; } static int i915_capabilities(struct seq_file *m, void *data) @@ -66,9 +66,15 @@ static int i915_capabilities(struct seq_file *m, void *data) #undef PRINT_FLAG kernel_param_lock(THIS_MODULE); -#define PRINT_PARAM(X, T, V, U, M, B, D) seq_print_param(m, #X, #T, &i915.X); +#define FLAG false +#define FLAG_unsafe true +#define PRINT_PARAM(X, T, V, U, M, B, D) \ + seq_print_param_##T(m, #X, i915.X, \ + param_tags(is_equal_##T(i915.X, V), FLAG##U)); I915_PARAMS_FOR_EACH(PRINT_PARAM); #undef PRINT_PARAM +#undef FLAG +#undef FLAG_unsafe kernel_param_unlock(THIS_MODULE); return 0;