diff mbox

[i-g-t,v2] lib/ioctl_wrappers: Fix function descriptions

Message ID 20170623140105.25550-1-radoslaw.szwichtenberg@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Szwichtenberg, Radoslaw June 23, 2017, 2:01 p.m. UTC 
Function description incorrectly stated that gem_context_get_param
and gem_context_set_param were freeing hw context.

v2: removed additional incorrect information

Signed-off-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
---
 lib/ioctl_wrappers.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Arkadiusz Hiler June 28, 2017, 10:47 a.m. UTC | #1 
On Fri, Jun 23, 2017 at 04:01:05PM +0200, Radoslaw Szwichtenberg wrote:
> Function description incorrectly stated that gem_context_get_param
> and gem_context_set_param were freeing hw context.
> 
> v2: removed additional incorrect information
> 
> Signed-off-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

I'll push it in a moment, thanks!

I followed up with a couple of similar fixes around the area, on top of
your patch.

Feel free to review them :-)
diff mbox

Patch

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 0816a7b..8e5ec88 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -977,10 +977,8 @@  int __gem_context_get_param(int fd, struct local_i915_gem_context_param *p)
  * @fd: open i915 drm file descriptor
  * @p: i915 hw context parameter
  *
- * This is a wraps the CONTEXT_GET_PARAM ioctl, which is used to free a hardware
- * context. Not that similarly to gem_set_caching() this wrapper calls
- * igt_require() internally to correctly skip on kernels and platforms where hw
- * context parameter support is not available.
+ * This is a wraps the CONTEXT_GET_PARAM ioctl, which is used to get a context
+ * parameter.
  */
 void gem_context_get_param(int fd, struct local_i915_gem_context_param *p)
 {
@@ -1003,10 +1001,8 @@  int __gem_context_set_param(int fd, struct local_i915_gem_context_param *p)
  * @fd: open i915 drm file descriptor
  * @p: i915 hw context parameter
  *
- * This is a wraps the CONTEXT_SET_PARAM ioctl, which is used to free a hardware
- * context. Not that similarly to gem_set_caching() this wrapper calls
- * igt_require() internally to correctly skip on kernels and platforms where hw
- * context parameter support is not available.
+ * This is a wraps the CONTEXT_SET_PARAM ioctl, which is used to set a context
+ * parameter.
  */
 void gem_context_set_param(int fd, struct local_i915_gem_context_param *p)
 {