From patchwork Wed Aug 23 22:40:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Puthikorn Voravootivat X-Patchwork-Id: 9918579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4D40603FA for ; Wed, 23 Aug 2017 22:41:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7F11288F8 for ; Wed, 23 Aug 2017 22:41:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ACD0028AA2; Wed, 23 Aug 2017 22:41:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 433FF288F8 for ; Wed, 23 Aug 2017 22:41:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBBE06E64A; Wed, 23 Aug 2017 22:41:12 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pg0-x234.google.com (mail-pg0-x234.google.com [IPv6:2607:f8b0:400e:c05::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7B046E64A for ; Wed, 23 Aug 2017 22:41:11 +0000 (UTC) Received: by mail-pg0-x234.google.com with SMTP id 83so6445399pgb.3 for ; Wed, 23 Aug 2017 15:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=ISSFOEuK9sSmKSXZbrDvzYOraQ3GnbhYkLKDpfCatfM=; b=T0KdhZ5TxKD9d+F1xxot2kjTUcOIrq7n6/Dffhkr4wzTvm0odFjTqIC6sC4o5wqBaz s2ZxTOLUlXyS4rzJJOiwM/LOrprVfjjkqQlon0fwJXqzaeCZO1cawh6ugnWPDoPOuh66 Ed9LmSgvWLEo2pp+t2qZTFhjqXfX34HaW83DnOB5K4/YXpL89q2GAEQeTq1CZlkKuEwq HKa+AnvRVOH6PfR7XpFemzBgUJ24ahnlILjreMJuSO5z1B9rc3dKy7uyGOpF8aDEKn9B wJRxToBDlcr2o7P2Q/Q32raN+ynToAk2e3pB2sAjvA1JyHAuYaFOCrMHAs84sifoWJ/Q MlOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=ISSFOEuK9sSmKSXZbrDvzYOraQ3GnbhYkLKDpfCatfM=; b=gS8mppi2bBZpdgBIP5JO/atod2CeHfeWtmTN1mX9drsBio5fe/G8seT4UlzgdJeQv4 J31QVCQgNUwrnoj1DmhbN4/l5NvEu9rgHNYJAoDJhyedA5G+YBrC1J7pKehKBbT2p7/+ DoGcOb8LgTB/e8le0Jsbu8nwBMAyBFkmn6YsM+MIl7KQoUv3wSESUvcESCt9v/bZmfNV Oeqp8EkilKr+PEwBIsl7Bn8xRVTVGHbMvbNKmtR6nCNmjlu/aYRsEgUebjNI0OGKyEct 2oGOKR38qTVgd+3epvycPmu/ZrI4dfEU8EPiYb6B6nvcM7vMF1DVDlX09gdh8iQ0+64V duZQ== X-Gm-Message-State: AHYfb5icvXNLG0eOauffT+s5dhDnzy2e7ZZ+yaX8Lcsg4mkykRDGEGNi FSLvdYqrtJHx/+Hn X-Google-Smtp-Source: ADKCNb560PAs8I7UPe76Jm+ZaFnfCD48t8FKL+bfao88KmGzNm+fvJUFEELlJtPVDedqE5Y6nlBfMw== X-Received: by 10.98.196.69 with SMTP id y66mr4344267pff.240.1503528070677; Wed, 23 Aug 2017 15:41:10 -0700 (PDT) Received: from puthik2.mtv.corp.google.com ([172.22.113.118]) by smtp.gmail.com with ESMTPSA id 133sm3786199pgc.19.2017.08.23.15.41.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Aug 2017 15:41:10 -0700 (PDT) Received: by puthik2.mtv.corp.google.com (Postfix, from userid 218808) id BA25D17F48D; Wed, 23 Aug 2017 15:41:08 -0700 (PDT) From: Puthikorn Voravootivat To: intel-gfx@lists.freedesktop.org Date: Wed, 23 Aug 2017 15:40:28 -0700 Message-Id: <20170823224028.18943-1-puthik@chromium.org> X-Mailer: git-send-email 2.14.1.342.g6490525c54-goog Cc: Puthikorn Voravootivat , Jim Bride , Dhinakaran Pandiyan , Rodrigo Vivi Subject: [Intel-gfx] [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP If the full detect is already done, we shouldn't need to do it again. This fixes the screen blinking issue that happen when calling DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking is caused by full dp detect in intel_dp_long_pulse(). Signed-off-by: Puthikorn Voravootivat --- drivers/gpu/drm/i915/intel_dp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index d3e5fdf0d2fa..152e7016d5f2 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector, if (!intel_dp->detect_done) status = intel_dp_long_pulse(intel_dp->attached_connector); - intel_dp->detect_done = false; - return status; }