From patchwork Tue Aug 29 10:32:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marta Lofstedt X-Patchwork-Id: 9927041 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B09286022E for ; Tue, 29 Aug 2017 10:27:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93D14288C3 for ; Tue, 29 Aug 2017 10:27:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 885F1288BD; Tue, 29 Aug 2017 10:27:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 88FE6288BD for ; Tue, 29 Aug 2017 10:27:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8637899DB; Tue, 29 Aug 2017 10:26:41 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E42F899DB for ; Tue, 29 Aug 2017 10:26:40 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 03:26:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.41,444,1498546800"; d="scan'208"; a="1211895967" Received: from mlofsted-dev-hsw.fi.intel.com (HELO localhost.localdomain) ([10.237.72.167]) by fmsmga002.fm.intel.com with ESMTP; 29 Aug 2017 03:26:38 -0700 From: Marta Lofstedt To: intel-gfx@lists.freedesktop.org Date: Tue, 29 Aug 2017 13:32:43 +0300 Message-Id: <20170829103243.2662-1-marta.lofstedt@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_params. This leads to segfault on machines where the subtest should be skipped. Signed-off-by: Marta Lofstedt Reviewed-by: Mika Kahola --- tests/kms_atomic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c index d77a526f..042a7c26 100644 --- a/tests/kms_atomic.c +++ b/tests/kms_atomic.c @@ -1596,6 +1596,7 @@ igt_main struct kms_atomic_connector_state *conn = find_connector(scratch, crtc); + igt_require(crtc); igt_require(plane); igt_require(conn); atomic_invalid_params(crtc, plane, conn);