From patchwork Tue Aug 29 18:55:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michel Thierry X-Patchwork-Id: 9927945 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0749E603B4 for ; Tue, 29 Aug 2017 18:56:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB35128A1C for ; Tue, 29 Aug 2017 18:56:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E024B28A23; Tue, 29 Aug 2017 18:56:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1199328A2A for ; Tue, 29 Aug 2017 18:56:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 034816E41C; Tue, 29 Aug 2017 18:55:48 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CEEE6E41C for ; Tue, 29 Aug 2017 18:55:45 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 11:55:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.41,445,1498546800"; d="scan'208"; a="1189471148" Received: from relo-linux-11.sc.intel.com ([10.3.160.161]) by fmsmga001.fm.intel.com with ESMTP; 29 Aug 2017 11:55:45 -0700 From: Michel Thierry To: intel-gfx@lists.freedesktop.org Date: Tue, 29 Aug 2017 11:55:45 -0700 Message-Id: <20170829185545.10169-1-michel.thierry@intel.com> X-Mailer: git-send-email 2.14.1 Subject: [Intel-gfx] [PATCH] drm/i915: Add a default case in gen7 hwsp switch-case X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Gen7 won't get any new engines, and we already added VCS2 there to just silence gcc's not-handled-in-switch warnings. Use a default case instead, otherwise we will need to keep adding extra cases if changes happen in the future. Signed-off-by: Michel Thierry Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index c277a26bbd99..7d57a5971f39 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -409,10 +409,12 @@ static void intel_ring_setup_status_page(struct intel_engine_cs *engine) mmio = BLT_HWS_PGA_GEN7; break; /* - * VCS2 actually doesn't exist on Gen7. Only shut up + * No more rings exist on Gen7. Only shut up * gcc switch check warning */ - case VCS2: + default: + MISSING_CASE(engine->id); + /* fall through */ case VCS: mmio = BSD_HWS_PGA_GEN7; break;