From patchwork Tue Oct 17 21:01:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Puthikorn Voravootivat X-Patchwork-Id: 10012861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 09E29600CC for ; Tue, 17 Oct 2017 21:02:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE03A28A3C for ; Tue, 17 Oct 2017 21:02:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E066628A3E; Tue, 17 Oct 2017 21:02:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 71E8028A3C for ; Tue, 17 Oct 2017 21:02:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3636D6E767; Tue, 17 Oct 2017 21:02:04 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEE1D6E767 for ; Tue, 17 Oct 2017 21:02:02 +0000 (UTC) Received: by mail-io0-x22b.google.com with SMTP id i38so3773670iod.2 for ; Tue, 17 Oct 2017 14:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=jxwqJ2CvLCoUwSMJ+Tj72d1pcs+1xahlbrWIkQ7Sjso=; b=CjFoX50KUgRR3iMopY4He+uW1fG4NMH7GVSaH1JBgX80Oi+TLZwsgalbIlMbl1sJsz T4flBPj1nyKFTds0fTCETYu4OulYt/plajjyjQe+MEZa4/kTu+hBPP3a0IPp69QaaICj 2MpDTdisRsORx3O9QHleOj2Nv6UahtYkEkNZ5kcTMPcr/MNRCiWeFod6dhHw2t5z56ZW 0xIXQ8IZP5W0p6eQTtDIFiu3rjhzMbK418v84w1cl8C2Z0l0K72P/1ie5BuEUc5Qu8YQ rtZ2IZo7VszABOFaNDvaYHJmWN/DHrfBwGCnS5DWhxI+/uCObZgkPDElVcDsl7dLdY9z 2GWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=jxwqJ2CvLCoUwSMJ+Tj72d1pcs+1xahlbrWIkQ7Sjso=; b=TLp3LrKdUDoWp6Bozcj+KebBFsVCVDELgvmpgreHZbStiJ7Q+XTW9tTvwNwjoVEOG4 sQhgnOLuo9Ydwyn/5VRlH809qzcBEQySTrkQRHqLRlVwwdrU0G+rjwXuQPQeQrG5Zf1l g2ZRMBCvC3OZFgCncILC/d4e8BEnXQ6PZ9DP9SwQm2f1mLjGlR3NnltyZwwofGv7QXi8 THu9hckZ6cKyjjV021FtIEe+92ggOmaaHFt4cEO1TvKhcYwNxzHv4cL8EzXWWIj9dEmd UyQMd2sunWwabSIe/coamaqcOyvR4awqaNyuUsNHepxQSlqzofSY65QtQe8a2z6/Q8ZG 1/Vw== X-Gm-Message-State: AMCzsaXWgHMZfVzZ97KHyfedwk9ThbYRykwylcUnUo1N2Lsb0uzpgg46 yZNUo73s56zSvxS99OkX86qosg== X-Google-Smtp-Source: ABhQp+SIFTQNFE/rQ3lb65RkaCYDkGqXk0w3J8x/6HTSIcnnRZ7poWaHe+abFia0eB8V4S2p9fbWMA== X-Received: by 10.107.181.200 with SMTP id e191mr10780798iof.284.1508274121453; Tue, 17 Oct 2017 14:02:01 -0700 (PDT) Received: from puthik2.mtv.corp.google.com ([172.22.113.118]) by smtp.gmail.com with ESMTPSA id g195sm5911784itc.14.2017.10.17.14.02.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 14:02:00 -0700 (PDT) Received: by puthik2.mtv.corp.google.com (Postfix, from userid 218808) id 0398817F69E; Tue, 17 Oct 2017 14:01:58 -0700 (PDT) From: Puthikorn Voravootivat To: intel-gfx@lists.freedesktop.org Date: Tue, 17 Oct 2017 14:01:56 -0700 Message-Id: <20171017210156.54601-1-puthik@chromium.org> X-Mailer: git-send-email 2.15.0.rc0.271.g36b669edcc-goog Cc: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Dhinakaran Pandiyan , Rodrigo Vivi , Puthikorn Voravootivat , Rich Chen Subject: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP intel_dp_long_pulse() is always checking link status because there has been known issues of link loss triggerring long pulse. However this is not needed for eDP display since we won't have link loss for internal display. Also there are reports that screens are flickering during link status check. (repro by running modetest command repeatedly) Signed-off-by: Puthikorn Voravootivat --- drivers/gpu/drm/i915/intel_dp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4b65cf137f79..75a77ef257e2 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -4763,7 +4763,8 @@ intel_dp_long_pulse(struct intel_connector *intel_connector) */ status = connector_status_disconnected; goto out; - } else { + } else if (status != connector_status_connected || + intel_encoder->type != INTEL_OUTPUT_EDP) { /* * If display is now connected check links status, * there has been known issues of link loss triggerring @@ -4775,6 +4776,10 @@ intel_dp_long_pulse(struct intel_connector *intel_connector) * going back up soon after. And once that happens we must * retrain the link to get a picture. That's in case no * userspace component reacted to intermittent HPD dip. + * + * Skip checking links status for connected eDP display. + * There are known issues of display blinking during checking + * link status and we don't have link loss for internal display. */ intel_dp_check_link_status(intel_dp); }