| Message ID | 20171215195936.28356-1-ajax@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Adam Jackson (2017-12-15 19:59:36) > Signed-off-by: Adam Jackson <ajax@redhat.com> > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c > index 9d90c69d..ce7da2c0 100644 > --- a/tools/intel_vbt_decode.c > +++ b/tools/intel_vbt_decode.c > @@ -309,8 +309,8 @@ static const struct { > { DEVICE_TYPE_COMPOSITE_OUTPUT, "Composite output" }, > { DEVICE_TYPE_DUAL_CHANNEL, "Dual channel" }, > { 1 << 7, "Content protection" }, > - { DEVICE_TYPE_HIGH_SPEED_LINK, "High speel link" }, > - { DEVICE_TYPE_LVDS_SINGALING, "LVDS signaling" }, It shall forever be known as sing-a-ling. :) -Chris
On Fri, Dec 15, 2017 at 02:59:36PM -0500, Adam Jackson wrote: > Signed-off-by: Adam Jackson <ajax@redhat.com> > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) This mail was rejected by Patchwork because of "X-Mailer" header, indicating that it was sent with git send-email, is missing. I forced it through manually, so we will have CI feedback soon (so very necessary for this complex patch :-P). May I ask why is the header missing from your patch? I wonder whether should we relax patchwork's checks.
On Fri, 15 Dec 2017, Adam Jackson <ajax@redhat.com> wrote: > Signed-off-by: Adam Jackson <ajax@redhat.com> > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- Hi Adam, thanks for the patch. We've opted to make the kernel copy of this file the single point of truth, and copy that over verbatim every once in a while. Please send a patch to drivers/gpu/drm/i915/intel_vbt_defs.h and it'll trickle over here eventually when we sync up (or you can send the sync patch too). Thanks, Jani. > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c > index 9d90c69d..ce7da2c0 100644 > --- a/tools/intel_vbt_decode.c > +++ b/tools/intel_vbt_decode.c > @@ -309,8 +309,8 @@ static const struct { > { DEVICE_TYPE_COMPOSITE_OUTPUT, "Composite output" }, > { DEVICE_TYPE_DUAL_CHANNEL, "Dual channel" }, > { 1 << 7, "Content protection" }, > - { DEVICE_TYPE_HIGH_SPEED_LINK, "High speel link" }, > - { DEVICE_TYPE_LVDS_SINGALING, "LVDS signaling" }, > + { DEVICE_TYPE_HIGH_SPEED_LINK, "High speed link" }, > + { DEVICE_TYPE_LVDS_SIGNALING, "LVDS signaling" }, > { DEVICE_TYPE_TMDS_DVI_SIGNALING, "TMDS/DVI signaling" }, > { DEVICE_TYPE_VIDEO_SIGNALING, "Video signaling" }, > { DEVICE_TYPE_DISPLAYPORT_OUTPUT, "DisplayPort output" }, > diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h > index 404569c9..e388f9ad 100644 > --- a/tools/intel_vbt_defs.h > +++ b/tools/intel_vbt_defs.h > @@ -227,7 +227,7 @@ struct bdb_general_features { > #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9) > #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8) > #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6) > -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5) > +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5) > #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4) > #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3) > #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2) > @@ -243,7 +243,7 @@ struct bdb_general_features { > DEVICE_TYPE_MIPI_OUTPUT | \ > DEVICE_TYPE_COMPOSITE_OUTPUT | \ > DEVICE_TYPE_DUAL_CHANNEL | \ > - DEVICE_TYPE_LVDS_SINGALING | \ > + DEVICE_TYPE_LVDS_SIGNALING | \ > DEVICE_TYPE_TMDS_DVI_SIGNALING | \ > DEVICE_TYPE_VIDEO_SIGNALING | \ > DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ > @@ -253,7 +253,7 @@ struct bdb_general_features { > (DEVICE_TYPE_INTERNAL_CONNECTOR | \ > DEVICE_TYPE_MIPI_OUTPUT | \ > DEVICE_TYPE_COMPOSITE_OUTPUT | \ > - DEVICE_TYPE_LVDS_SINGALING | \ > + DEVICE_TYPE_LVDS_SIGNALING | \ > DEVICE_TYPE_TMDS_DVI_SIGNALING | \ > DEVICE_TYPE_VIDEO_SIGNALING | \ > DEVICE_TYPE_DISPLAYPORT_OUTPUT | \
On Fri, 15 Dec 2017, Adam Jackson <ajax@redhat.com> wrote: > Signed-off-by: Adam Jackson <ajax@redhat.com> Finally pushed, thanks for the patch. BR, Jani. > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c > index 9d90c69d..ce7da2c0 100644 > --- a/tools/intel_vbt_decode.c > +++ b/tools/intel_vbt_decode.c > @@ -309,8 +309,8 @@ static const struct { > { DEVICE_TYPE_COMPOSITE_OUTPUT, "Composite output" }, > { DEVICE_TYPE_DUAL_CHANNEL, "Dual channel" }, > { 1 << 7, "Content protection" }, > - { DEVICE_TYPE_HIGH_SPEED_LINK, "High speel link" }, > - { DEVICE_TYPE_LVDS_SINGALING, "LVDS signaling" }, > + { DEVICE_TYPE_HIGH_SPEED_LINK, "High speed link" }, > + { DEVICE_TYPE_LVDS_SIGNALING, "LVDS signaling" }, > { DEVICE_TYPE_TMDS_DVI_SIGNALING, "TMDS/DVI signaling" }, > { DEVICE_TYPE_VIDEO_SIGNALING, "Video signaling" }, > { DEVICE_TYPE_DISPLAYPORT_OUTPUT, "DisplayPort output" }, > diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h > index 404569c9..e388f9ad 100644 > --- a/tools/intel_vbt_defs.h > +++ b/tools/intel_vbt_defs.h > @@ -227,7 +227,7 @@ struct bdb_general_features { > #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9) > #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8) > #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6) > -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5) > +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5) > #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4) > #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3) > #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2) > @@ -243,7 +243,7 @@ struct bdb_general_features { > DEVICE_TYPE_MIPI_OUTPUT | \ > DEVICE_TYPE_COMPOSITE_OUTPUT | \ > DEVICE_TYPE_DUAL_CHANNEL | \ > - DEVICE_TYPE_LVDS_SINGALING | \ > + DEVICE_TYPE_LVDS_SIGNALING | \ > DEVICE_TYPE_TMDS_DVI_SIGNALING | \ > DEVICE_TYPE_VIDEO_SIGNALING | \ > DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ > @@ -253,7 +253,7 @@ struct bdb_general_features { > (DEVICE_TYPE_INTERNAL_CONNECTOR | \ > DEVICE_TYPE_MIPI_OUTPUT | \ > DEVICE_TYPE_COMPOSITE_OUTPUT | \ > - DEVICE_TYPE_LVDS_SINGALING | \ > + DEVICE_TYPE_LVDS_SIGNALING | \ > DEVICE_TYPE_TMDS_DVI_SIGNALING | \ > DEVICE_TYPE_VIDEO_SIGNALING | \ > DEVICE_TYPE_DISPLAYPORT_OUTPUT | \
diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c index 9d90c69d..ce7da2c0 100644 --- a/tools/intel_vbt_decode.c +++ b/tools/intel_vbt_decode.c @@ -309,8 +309,8 @@ static const struct { { DEVICE_TYPE_COMPOSITE_OUTPUT, "Composite output" }, { DEVICE_TYPE_DUAL_CHANNEL, "Dual channel" }, { 1 << 7, "Content protection" }, - { DEVICE_TYPE_HIGH_SPEED_LINK, "High speel link" }, - { DEVICE_TYPE_LVDS_SINGALING, "LVDS signaling" }, + { DEVICE_TYPE_HIGH_SPEED_LINK, "High speed link" }, + { DEVICE_TYPE_LVDS_SIGNALING, "LVDS signaling" }, { DEVICE_TYPE_TMDS_DVI_SIGNALING, "TMDS/DVI signaling" }, { DEVICE_TYPE_VIDEO_SIGNALING, "Video signaling" }, { DEVICE_TYPE_DISPLAYPORT_OUTPUT, "DisplayPort output" }, diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h index 404569c9..e388f9ad 100644 --- a/tools/intel_vbt_defs.h +++ b/tools/intel_vbt_defs.h @@ -227,7 +227,7 @@ struct bdb_general_features { #define DEVICE_TYPE_COMPOSITE_OUTPUT (1 << 9) #define DEVICE_TYPE_DUAL_CHANNEL (1 << 8) #define DEVICE_TYPE_HIGH_SPEED_LINK (1 << 6) -#define DEVICE_TYPE_LVDS_SINGALING (1 << 5) +#define DEVICE_TYPE_LVDS_SIGNALING (1 << 5) #define DEVICE_TYPE_TMDS_DVI_SIGNALING (1 << 4) #define DEVICE_TYPE_VIDEO_SIGNALING (1 << 3) #define DEVICE_TYPE_DISPLAYPORT_OUTPUT (1 << 2) @@ -243,7 +243,7 @@ struct bdb_general_features { DEVICE_TYPE_MIPI_OUTPUT | \ DEVICE_TYPE_COMPOSITE_OUTPUT | \ DEVICE_TYPE_DUAL_CHANNEL | \ - DEVICE_TYPE_LVDS_SINGALING | \ + DEVICE_TYPE_LVDS_SIGNALING | \ DEVICE_TYPE_TMDS_DVI_SIGNALING | \ DEVICE_TYPE_VIDEO_SIGNALING | \ DEVICE_TYPE_DISPLAYPORT_OUTPUT | \ @@ -253,7 +253,7 @@ struct bdb_general_features { (DEVICE_TYPE_INTERNAL_CONNECTOR | \ DEVICE_TYPE_MIPI_OUTPUT | \ DEVICE_TYPE_COMPOSITE_OUTPUT | \ - DEVICE_TYPE_LVDS_SINGALING | \ + DEVICE_TYPE_LVDS_SIGNALING | \ DEVICE_TYPE_TMDS_DVI_SIGNALING | \ DEVICE_TYPE_VIDEO_SIGNALING | \ DEVICE_TYPE_DISPLAYPORT_OUTPUT | \
Signed-off-by: Adam Jackson <ajax@redhat.com> --- tools/intel_vbt_decode.c | 4 ++-- tools/intel_vbt_defs.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)