diff mbox

[i-g-t,1/2] test/kms_psr_sink_crc - subtests psr_basic and psr_drrs need test cleanup

Message ID 20180104140702.5203-1-marta.lofstedt@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Marta Lofstedt Jan. 4, 2018, 2:07 p.m. UTC
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/kms_psr_sink_crc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dhinakaran Pandiyan Jan. 4, 2018, 11:23 p.m. UTC | #1
Including a line about the atomic update failure in the commit message
would be nice.

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>


On Thu, 2018-01-04 at 16:07 +0200, Marta Lofstedt wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

> 

> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>

> ---

>  tests/kms_psr_sink_crc.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c

> index 83a69f0b..26cf434a 100644

> --- a/tests/kms_psr_sink_crc.c

> +++ b/tests/kms_psr_sink_crc.c

> @@ -532,11 +532,13 @@ int main(int argc, char *argv[])

>  	igt_subtest("psr_basic") {

>  		setup_test_plane(&data);

>  		igt_assert(wait_psr_entry(&data));

> +		test_cleanup(&data);

>  	}

>  

>  	igt_subtest("psr_drrs") {

>  		setup_test_plane(&data);

>  		igt_assert(drrs_disabled(&data));

> +		test_cleanup(&data);

>  	}

>  

>  	for (op = PAGE_FLIP; op <= RENDER; op++) {
Marta Lofstedt Jan. 5, 2018, 8:12 a.m. UTC | #2
Arek,
I didn't get any PW for this maybe because I sent it together with a HACK patch to get a test run on BAT.

Should I rename both patches and re-send to the list?

/Marta

> -----Original Message-----
> From: Lofstedt, Marta
> Sent: Thursday, January 4, 2018 4:07 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala@intel.com>; Lofstedt, Marta
> <marta.lofstedt@intel.com>
> Subject: [PATCH i-g-t 1/2] test/kms_psr_sink_crc - subtests psr_basic and
> psr_drrs need test cleanup
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> 
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index
> 83a69f0b..26cf434a 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -532,11 +532,13 @@ int main(int argc, char *argv[])
>  	igt_subtest("psr_basic") {
>  		setup_test_plane(&data);
>  		igt_assert(wait_psr_entry(&data));
> +		test_cleanup(&data);
>  	}
> 
>  	igt_subtest("psr_drrs") {
>  		setup_test_plane(&data);
>  		igt_assert(drrs_disabled(&data));
> +		test_cleanup(&data);
>  	}
> 
>  	for (op = PAGE_FLIP; op <= RENDER; op++) {
> --
> 2.11.0
diff mbox

Patch

diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 83a69f0b..26cf434a 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/kms_psr_sink_crc.c
@@ -532,11 +532,13 @@  int main(int argc, char *argv[])
 	igt_subtest("psr_basic") {
 		setup_test_plane(&data);
 		igt_assert(wait_psr_entry(&data));
+		test_cleanup(&data);
 	}
 
 	igt_subtest("psr_drrs") {
 		setup_test_plane(&data);
 		igt_assert(drrs_disabled(&data));
+		test_cleanup(&data);
 	}
 
 	for (op = PAGE_FLIP; op <= RENDER; op++) {