From patchwork Tue Jan 16 11:13:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petri Latvala X-Patchwork-Id: 10166537 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9CF7F601E7 for ; Tue, 16 Jan 2018 11:15:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A71D20881 for ; Tue, 16 Jan 2018 11:15:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8E0C021BED; Tue, 16 Jan 2018 11:15:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4F8EC20881 for ; Tue, 16 Jan 2018 11:15:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CA388989F; Tue, 16 Jan 2018 11:15:31 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id EAD9289830; Tue, 16 Jan 2018 11:15:27 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2018 03:15:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,368,1511856000"; d="scan'208";a="19791755" Received: from thrakatuluk.fi.intel.com (HELO thrakatuluk) ([10.237.68.137]) by orsmga003.jf.intel.com with ESMTP; 16 Jan 2018 03:15:25 -0800 Received: from platvala by thrakatuluk with local (Exim 4.89) (envelope-from ) id 1ebPDA-0001r9-HP; Tue, 16 Jan 2018 13:15:24 +0200 From: Petri Latvala To: igt-dev@lists.freedesktop.org Date: Tue, 16 Jan 2018 13:13:05 +0200 Message-Id: <20180116111306.7080-3-petri.latvala@intel.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180116111306.7080-1-petri.latvala@intel.com> References: <20180116111306.7080-1-petri.latvala@intel.com> Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH i-g-t 3/4] meson: Add quotes in assembler/test/run-test.sh X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP If the directories contain spaces, run-test.sh fails. Signed-off-by: Petri Latvala --- assembler/test/run-test.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh index b06e1044..f5e1a8fb 100644 --- a/assembler/test/run-test.sh +++ b/assembler/test/run-test.sh @@ -1,7 +1,7 @@ #!/bin/sh -SRCDIR=${srcdir-`pwd`} -BUILDDIR=${top_builddir-`pwd`} +SRCDIR="${srcdir-`pwd`}" +BUILDDIR="${top_builddir-`pwd`}" test="TEST" @@ -9,11 +9,11 @@ if [ -n "$1" ] ; then test="$1" fi -test -d ${BUILDDIR}/test || mkdir ${BUILDDIR}/test/ +test -d "${BUILDDIR}/test" || mkdir "${BUILDDIR}/test/" -${BUILDDIR}/intel-gen4asm -o ${BUILDDIR}/${test}.out $SRCDIR/${test}.g4a -if cmp ${BUILDDIR}/${test}.out ${SRCDIR}/${test}.expected 2> /dev/null; then : ; else +"${BUILDDIR}/intel-gen4asm" -o "${BUILDDIR}/${test}.out" "$SRCDIR/${test}.g4a" +if cmp "${BUILDDIR}/${test}.out" "${SRCDIR}/${test}.expected" 2> /dev/null; then : ; else echo "Output comparison for ${test}" - diff -u ${SRCDIR}/${test}.expected ${test}.out + diff -u "${SRCDIR}/${test}.expected" "${test}.out" exit 1; fi