From patchwork Tue Mar 13 14:52:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 10279215 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3265660231 for ; Tue, 13 Mar 2018 14:54:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23AF829107 for ; Tue, 13 Mar 2018 14:54:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 227C82910B; Tue, 13 Mar 2018 14:54:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BC84729400 for ; Tue, 13 Mar 2018 14:52:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB3B26E557; Tue, 13 Mar 2018 14:52:37 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 952AF6E557 for ; Tue, 13 Mar 2018 14:52:35 +0000 (UTC) Received: by mail.bootlin.com (Postfix, from userid 110) id A639520731; Tue, 13 Mar 2018 15:52:33 +0100 (CET) Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 5E2582036E; Tue, 13 Mar 2018 15:52:23 +0100 (CET) From: Maxime Ripard To: intel-gfx@lists.freedesktop.org Date: Tue, 13 Mar 2018 15:52:23 +0100 Message-Id: <20180313145223.21923-1-maxime.ripard@bootlin.com> X-Mailer: git-send-email 2.14.3 Subject: [Intel-gfx] [PATCH i-g-t] HACK: enable the chamelium HDMI-CRC-multiple test X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , "Sarvela, Tomi P" , Paul Kocialkowski MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP It seems like there's a regression (at least using the vc4 DRM display driver) when doing multiple calls to tests/kms_chamelium.c enable_output after a single prepare_output. Indeed, the DRM atomic_state doesn't seem to be full on the second run, especially for the CRTC that doesn't have any encoder or connector enabled (and isn't set as active). This will later fail here: https://elixir.bootlin.com/linux/v4.16-rc5/source/drivers/gpu/drm/drm_atomic_helper.c#L607 With the atomic_commit failing. This went unnoticed mostly because all the chamelium test cases that are enabled in the test suites do not follow that pattern. Since there's nothing really driver specific and it all seems that the generic code in IGT is doing something wrong, let's try to run it on intel's GPU to confirm (or deny) that it's broken for everyone. Signed-off-by: Maxime Ripard --- tests/intel-ci/fast-feedback.testlist | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index f71a16bcd191..847889d7220f 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -204,6 +204,7 @@ igt@kms_chamelium@dp-crc-fast igt@kms_chamelium@hdmi-hpd-fast igt@kms_chamelium@hdmi-edid-read igt@kms_chamelium@hdmi-crc-fast +igt@kms_chamelium@hdmi-crc-multiple igt@kms_chamelium@vga-hpd-fast igt@kms_chamelium@vga-edid-read igt@kms_chamelium@common-hpd-after-suspend