diff mbox series

[4/7] drm/i915/icl: WaSendPushConstantsFromMMIO

Message ID 20180928164738.9756-4-radhakrishna.sripada@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/7] drm/i915/icl: Add WaEnable32PlaneMode | expand

Commit Message

Sripada, Radhakrishna Sept. 28, 2018, 4:47 p.m. UTC 
From: Oscar Mateo <oscar.mateo@intel.com>

Allows UMDs to set 'Disable Gather at Set Shader Common Slice'.

Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/intel_workarounds.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chris Wilson Sept. 28, 2018, 4:53 p.m. UTC | #1 
Quoting Radhakrishna Sripada (2018-09-28 17:47:35)
> From: Oscar Mateo <oscar.mateo@intel.com>
> 
> Allows UMDs to set 'Disable Gather at Set Shader Common Slice'.

Question for reviewers is what other bits are exposed here?
-Chris
Mika Kuoppala Oct. 1, 2018, 10:40 a.m. UTC | #2 
Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Radhakrishna Sripada (2018-09-28 17:47:35)
>> From: Oscar Mateo <oscar.mateo@intel.com>
>> 
>> Allows UMDs to set 'Disable Gather at Set Shader Common Slice'.
>
> Question for reviewers is what other bits are exposed here?

And we would also need to have a mesa/umd side commit/ack
to demonstrate that this is desired and really needed.

-Mika

> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen Oct. 1, 2018, 10:48 a.m. UTC | #3 
Why is this mixed with display workarounds?

These were already once on the list and were decided not to be included
as there are no known users.

Regards, Joonas

Quoting Radhakrishna Sripada (2018-09-28 19:47:35)
> From: Oscar Mateo <oscar.mateo@intel.com>
> 
> Allows UMDs to set 'Disable Gather at Set Shader Common Slice'.
> 
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_workarounds.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index ba4009b4ad2c..d0a982868964 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -1013,6 +1013,8 @@ static void cnl_whitelist_build(struct whitelist *w)
>  
>  static void icl_whitelist_build(struct whitelist *w)
>  {
> +       /* WaSendPushConstantsFromMMIO:icl */
> +       whitelist_reg(w, COMMON_SLICE_CHICKEN2);
>  }
>  
>  static struct whitelist *whitelist_build(struct intel_engine_cs *engine,
> -- 
> 2.9.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
index ba4009b4ad2c..d0a982868964 100644
--- a/drivers/gpu/drm/i915/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/intel_workarounds.c
@@ -1013,6 +1013,8 @@  static void cnl_whitelist_build(struct whitelist *w)
 
 static void icl_whitelist_build(struct whitelist *w)
 {
+	/* WaSendPushConstantsFromMMIO:icl */
+	whitelist_reg(w, COMMON_SLICE_CHICKEN2);
 }
 
 static struct whitelist *whitelist_build(struct intel_engine_cs *engine,