diff mbox series

drm/i915/guc: remove unneeded goto from selftest

Message ID 20181019211657.6118-1-daniele.ceraolospurio@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/guc: remove unneeded goto from selftest | expand

Commit Message

Daniele Ceraolo Spurio Oct. 19, 2018, 9:16 p.m. UTC
commit e346a991f42c ("drm/i915/guc: drop negative doorbell alloc
selftest") removed the negative case from the selftest and left no
code between the goto from the positive case of the test and the label
itself, so we can get rid of it.

Reported-by: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/i915/selftests/intel_guc.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Lucas De Marchi Oct. 19, 2018, 9:20 p.m. UTC | #1
On Fri, Oct 19, 2018 at 02:16:57PM -0700, Daniele Ceraolo Spurio wrote:
> commit e346a991f42c ("drm/i915/guc: drop negative doorbell alloc
> selftest") removed the negative case from the selftest and left no
> code between the goto from the positive case of the test and the label
> itself, so we can get rid of it.
> 
> Reported-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

thanks
Lucas De Marchi

> ---
>  drivers/gpu/drm/i915/selftests/intel_guc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/intel_guc.c b/drivers/gpu/drm/i915/selftests/intel_guc.c
> index 464f7d5defad..32cba4cae31a 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_guc.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_guc.c
> @@ -214,8 +214,6 @@ static int igt_guc_clients(void *args)
>  	 * client it is currently assigned should not cause a failure.
>  	 */
>  	err = create_doorbell(guc->execbuf_client);
> -	if (err)
> -		goto out;
>  
>  out:
>  	/*
> -- 
> 2.19.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/selftests/intel_guc.c b/drivers/gpu/drm/i915/selftests/intel_guc.c
index 464f7d5defad..32cba4cae31a 100644
--- a/drivers/gpu/drm/i915/selftests/intel_guc.c
+++ b/drivers/gpu/drm/i915/selftests/intel_guc.c
@@ -214,8 +214,6 @@  static int igt_guc_clients(void *args)
 	 * client it is currently assigned should not cause a failure.
 	 */
 	err = create_doorbell(guc->execbuf_client);
-	if (err)
-		goto out;
 
 out:
 	/*