mbox series

[PULL] gvt-next-fixes for 4.20

Message ID 20181023034658.GU4714@zhen-hp.sh.intel.com (mailing list archive)
State New, archived
Headers show
Series [PULL] gvt-next-fixes for 4.20 | expand

Pull-request

https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-10-23

Message

Zhenyu Wang Oct. 23, 2018, 3:46 a.m. UTC 
Hi,

Here's gvt-next-fixes for 4.20 with three changes. Mostly
to fix possible arbitrary update on guest GGTT entry and
with proper invalidate of old entry. Another one for one
chicken reg mask fix.

thanks
--
The following changes since commit 835fe6d75d14c1513910ed7f5665127fee12acc8:

  firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (2018-10-18 10:36:10 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-10-23

for you to fetch changes up to 3e740f0ec37acecaa364c19d2d2826df83c8bf20:

  drm/i915/gvt: correct mask setting for CSFE_CHICKEN1 (2018-10-19 11:32:41 +0800)

----------------------------------------------------------------
gvt-next-fixes-2018-10-23

- Fix invalidate of old ggtt entry (Hang)
- Fix partial ggtt entry update in any order (Hang)
- Fix one mask setting for chicken reg (Xinyun)

----------------------------------------------------------------
Hang Yuan (2):
      drm/i915/gvt: invalidate old ggtt page when update ggtt entry
      drm/i915/gvt: support inconsecutive partial gtt entry write

Xinyun Liu (1):
      drm/i915/gvt: correct mask setting for CSFE_CHICKEN1

 drivers/gpu/drm/i915/gvt/gtt.c          | 115 ++++++++++++++++----------------
 drivers/gpu/drm/i915/gvt/gtt.h          |   9 ++-
 drivers/gpu/drm/i915/gvt/mmio_context.c |   2 +-
 3 files changed, 66 insertions(+), 60 deletions(-)

Comments

Joonas Lahtinen Oct. 25, 2018, 1:07 p.m. UTC | #1 
Quoting Zhenyu Wang (2018-10-23 06:46:59)
> 
> Hi,
> 
> Here's gvt-next-fixes for 4.20 with three changes. Mostly
> to fix possible arbitrary update on guest GGTT entry and
> with proper invalidate of old entry. Another one for one
> chicken reg mask fix.
> 
> thanks

Hi,

DIM seems to be (rightfully) complaining about one commit:

3e740f0ec37acecaa364c19d2d2826df83c8bf20 is lacking committer of sign-off

Probably better if you re-submit the PR for -fixes (rebased for
v4.20-rc1).

Regards, Joonas

> --
> The following changes since commit 835fe6d75d14c1513910ed7f5665127fee12acc8:
> 
>   firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (2018-10-18 10:36:10 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-10-23
> 
> for you to fetch changes up to 3e740f0ec37acecaa364c19d2d2826df83c8bf20:
> 
>   drm/i915/gvt: correct mask setting for CSFE_CHICKEN1 (2018-10-19 11:32:41 +0800)
> 
> ----------------------------------------------------------------
> gvt-next-fixes-2018-10-23
> 
> - Fix invalidate of old ggtt entry (Hang)
> - Fix partial ggtt entry update in any order (Hang)
> - Fix one mask setting for chicken reg (Xinyun)
> 
> ----------------------------------------------------------------
> Hang Yuan (2):
>       drm/i915/gvt: invalidate old ggtt page when update ggtt entry
>       drm/i915/gvt: support inconsecutive partial gtt entry write
> 
> Xinyun Liu (1):
>       drm/i915/gvt: correct mask setting for CSFE_CHICKEN1
> 
>  drivers/gpu/drm/i915/gvt/gtt.c          | 115 ++++++++++++++++----------------
>  drivers/gpu/drm/i915/gvt/gtt.h          |   9 ++-
>  drivers/gpu/drm/i915/gvt/mmio_context.c |   2 +-
>  3 files changed, 66 insertions(+), 60 deletions(-)
> 
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Rodrigo Vivi Oct. 25, 2018, 6:28 p.m. UTC | #2 
On Thu, Oct 25, 2018 at 04:07:14PM +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2018-10-23 06:46:59)
> > 
> > Hi,
> > 
> > Here's gvt-next-fixes for 4.20 with three changes. Mostly
> > to fix possible arbitrary update on guest GGTT entry and
> > with proper invalidate of old entry. Another one for one
> > chicken reg mask fix.
> > 
> > thanks
> 
> Hi,
> 
> DIM seems to be (rightfully) complaining about one commit:
> 
> 3e740f0ec37acecaa364c19d2d2826df83c8bf20 is lacking committer of sign-off

This is something I'm asking gvt for a while already:
Please make review mandatory on your side.

> 
> Probably better if you re-submit the PR for -fixes (rebased for
> v4.20-rc1).
> 
> Regards, Joonas
> 
> > --
> > The following changes since commit 835fe6d75d14c1513910ed7f5665127fee12acc8:
> > 
> >   firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (2018-10-18 10:36:10 +0300)
> > 
> > are available in the Git repository at:
> > 
> >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-10-23
> > 
> > for you to fetch changes up to 3e740f0ec37acecaa364c19d2d2826df83c8bf20:
> > 
> >   drm/i915/gvt: correct mask setting for CSFE_CHICKEN1 (2018-10-19 11:32:41 +0800)
> > 
> > ----------------------------------------------------------------
> > gvt-next-fixes-2018-10-23
> > 
> > - Fix invalidate of old ggtt entry (Hang)
> > - Fix partial ggtt entry update in any order (Hang)
> > - Fix one mask setting for chicken reg (Xinyun)
> > 
> > ----------------------------------------------------------------
> > Hang Yuan (2):
> >       drm/i915/gvt: invalidate old ggtt page when update ggtt entry
> >       drm/i915/gvt: support inconsecutive partial gtt entry write
> > 
> > Xinyun Liu (1):
> >       drm/i915/gvt: correct mask setting for CSFE_CHICKEN1
> > 
> >  drivers/gpu/drm/i915/gvt/gtt.c          | 115 ++++++++++++++++----------------
> >  drivers/gpu/drm/i915/gvt/gtt.h          |   9 ++-
> >  drivers/gpu/drm/i915/gvt/mmio_context.c |   2 +-
> >  3 files changed, 66 insertions(+), 60 deletions(-)
> > 
> > 
> > -- 
> > Open Source Technology Center, Intel ltd.
> > 
> > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Zhenyu Wang Oct. 26, 2018, 2:44 a.m. UTC | #3 
On 2018.10.25 11:28:28 -0700, Rodrigo Vivi wrote:
> On Thu, Oct 25, 2018 at 04:07:14PM +0300, Joonas Lahtinen wrote:
> > Quoting Zhenyu Wang (2018-10-23 06:46:59)
> > > 
> > > Hi,
> > > 
> > > Here's gvt-next-fixes for 4.20 with three changes. Mostly
> > > to fix possible arbitrary update on guest GGTT entry and
> > > with proper invalidate of old entry. Another one for one
> > > chicken reg mask fix.
> > > 
> > > thanks
> > 
> > Hi,
> > 
> > DIM seems to be (rightfully) complaining about one commit:
> > 
> > 3e740f0ec37acecaa364c19d2d2826df83c8bf20 is lacking committer of sign-off
> 
> This is something I'm asking gvt for a while already:
> Please make review mandatory on your side.
>

yes, we are appling review process more strictly on gvt side,
that one should be reviewed by Zhi when I was offline, but he
seems forget to add r-b and I forgot to sign-off...Sorry for that,
will regenerate.
Zhenyu Wang Oct. 26, 2018, 6:43 a.m. UTC | #4 
On 2018.10.25 16:07:14 +0300, Joonas Lahtinen wrote:
> Quoting Zhenyu Wang (2018-10-23 06:46:59)
> > 
> > Hi,
> > 
> > Here's gvt-next-fixes for 4.20 with three changes. Mostly
> > to fix possible arbitrary update on guest GGTT entry and
> > with proper invalidate of old entry. Another one for one
> > chicken reg mask fix.
> > 
> > thanks
> 
> Hi,
> 
> DIM seems to be (rightfully) complaining about one commit:
> 
> 3e740f0ec37acecaa364c19d2d2826df83c8bf20 is lacking committer of sign-off
> 
> Probably better if you re-submit the PR for -fixes (rebased for
> v4.20-rc1).
> 

Looks -fixes is still 4.19? So I still regenerate against -next-fixes,
let me know if that's ok for you.

Thanks
--

The following changes since commit 835fe6d75d14c1513910ed7f5665127fee12acc8:

  firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (2018-10-18 10:36:10 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-10-26

for you to fetch changes up to 348589205265049eda2e365371eec18d56809699:

  drm/i915/gvt: correct mask setting for CSFE_CHICKEN1 (2018-10-26 10:57:48 +0800)

----------------------------------------------------------------
gvt-next-fixes-2018-10-26

- Fix invalidate of old ggtt entry (Hang)
- Fix partial ggtt entry update in any order (Hang)
- Fix one mask setting for chicken reg (Xinyun)

----------------------------------------------------------------
Hang Yuan (2):
      drm/i915/gvt: invalidate old ggtt page when update ggtt entry
      drm/i915/gvt: support inconsecutive partial gtt entry write

Xinyun Liu (1):
      drm/i915/gvt: correct mask setting for CSFE_CHICKEN1

 drivers/gpu/drm/i915/gvt/gtt.c          | 115 ++++++++++++++++----------------
 drivers/gpu/drm/i915/gvt/gtt.h          |   9 ++-
 drivers/gpu/drm/i915/gvt/mmio_context.c |   2 +-
 3 files changed, 66 insertions(+), 60 deletions(-)
Joonas Lahtinen Nov. 6, 2018, 5:03 p.m. UTC | #5 
Quoting Zhenyu Wang (2018-10-26 09:43:20)
> On 2018.10.25 16:07:14 +0300, Joonas Lahtinen wrote:
> > Quoting Zhenyu Wang (2018-10-23 06:46:59)
> > > 
> > > Hi,
> > > 
> > > Here's gvt-next-fixes for 4.20 with three changes. Mostly
> > > to fix possible arbitrary update on guest GGTT entry and
> > > with proper invalidate of old entry. Another one for one
> > > chicken reg mask fix.
> > > 
> > > thanks
> > 
> > Hi,
> > 
> > DIM seems to be (rightfully) complaining about one commit:
> > 
> > 3e740f0ec37acecaa364c19d2d2826df83c8bf20 is lacking committer of sign-off
> > 
> > Probably better if you re-submit the PR for -fixes (rebased for
> > v4.20-rc1).
> > 
> 
> Looks -fixes is still 4.19? So I still regenerate against -next-fixes,
> let me know if that's ok for you.

Ok, I've now pushed first set of -fixes aiming at v4.20-rc2 to
drm-intel-fixes. Now is good time to respin.

Regards, Joonas

> 
> Thanks
> --
> 
> The following changes since commit 835fe6d75d14c1513910ed7f5665127fee12acc8:
> 
>   firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (2018-10-18 10:36:10 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2018-10-26
> 
> for you to fetch changes up to 348589205265049eda2e365371eec18d56809699:
> 
>   drm/i915/gvt: correct mask setting for CSFE_CHICKEN1 (2018-10-26 10:57:48 +0800)
> 
> ----------------------------------------------------------------
> gvt-next-fixes-2018-10-26
> 
> - Fix invalidate of old ggtt entry (Hang)
> - Fix partial ggtt entry update in any order (Hang)
> - Fix one mask setting for chicken reg (Xinyun)
> 
> ----------------------------------------------------------------
> Hang Yuan (2):
>       drm/i915/gvt: invalidate old ggtt page when update ggtt entry
>       drm/i915/gvt: support inconsecutive partial gtt entry write
> 
> Xinyun Liu (1):
>       drm/i915/gvt: correct mask setting for CSFE_CHICKEN1
> 
>  drivers/gpu/drm/i915/gvt/gtt.c          | 115 ++++++++++++++++----------------
>  drivers/gpu/drm/i915/gvt/gtt.h          |   9 ++-
>  drivers/gpu/drm/i915/gvt/mmio_context.c |   2 +-
>  3 files changed, 66 insertions(+), 60 deletions(-)
> 
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827