diff mbox series

[CI,1/4] drm/i915: Kill WA 0528

Message ID 20181031162845.12419-1-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show
Series [CI,1/4] drm/i915: Kill WA 0528 | expand

Commit Message

Rodrigo Vivi Oct. 31, 2018, 4:28 p.m. UTC 
First of all I believe this WA as written here was wrong.

Because it is listed on BSpec only for SKL and BXT, exactly
the only 2 platforms skipped here.

But also it is written there that we don't need this WA
anymore:
"This workaround is no longer needed since NV12 support is
dropped for the affected projects in #0870."

SO, let's kill it.

Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Rodrigo Vivi Nov. 1, 2018, 6:27 p.m. UTC | #1 
On Thu, Nov 01, 2018 at 12:44:02AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [CI,1/4] drm/i915: Kill WA 0528
> URL   : https://patchwork.freedesktop.org/series/51826/
> State : success

series pushed to dinq. thanks for reviews.

> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_5062_full -> Patchwork_10673_full =
> 
> == Summary - WARNING ==
> 
>   Minor unknown changes coming with Patchwork_10673_full need to be verified
>   manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_10673_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> == Possible new issues ==
> 
>   Here are the unknown changes that may have been introduced in Patchwork_10673_full:
> 
>   === IGT changes ===
> 
>     ==== Warnings ====
> 
>     igt@pm_rc6_residency@rc6-accuracy:
>       shard-snb:          PASS -> SKIP
> 
>     
> == Known issues ==
> 
>   Here are the changes found in Patchwork_10673_full that come from known issues:
> 
>   === IGT changes ===
> 
>     ==== Issues hit ====
> 
>     igt@gem_exec_schedule@pi-ringfull-bsd:
>       shard-skl:          NOTRUN -> FAIL (fdo#103158)
> 
>     igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
>       shard-skl:          PASS -> FAIL (fdo#107815, fdo#108470, fdo#108228)
> 
>     igt@kms_available_modes_crc@available_mode_test_crc:
>       shard-apl:          PASS -> FAIL (fdo#106641)
> 
>     igt@kms_cursor_crc@cursor-128x128-onscreen:
>       shard-apl:          PASS -> FAIL (fdo#103232) +2
> 
>     igt@kms_cursor_crc@cursor-128x128-suspend:
>       shard-skl:          PASS -> INCOMPLETE (fdo#104108)
> 
>     igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
>       shard-glk:          NOTRUN -> FAIL (fdo#105454, fdo#106509)
> 
>     igt@kms_flip_tiling@flip-yf-tiled:
>       shard-apl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +6
> 
>     igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
>       shard-apl:          PASS -> FAIL (fdo#103167) +2
> 
>     igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
>       shard-skl:          PASS -> FAIL (fdo#107362, fdo#103191)
> 
>     igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
>       shard-apl:          NOTRUN -> FAIL (fdo#108145)
> 
>     igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>       shard-skl:          PASS -> FAIL (fdo#107815)
> 
>     igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
>       shard-glk:          NOTRUN -> FAIL (fdo#108145)
> 
>     igt@perf_pmu@enable-race-vecs0:
>       shard-apl:          PASS -> INCOMPLETE (fdo#103927)
> 
>     
>     ==== Possible fixes ====
> 
>     igt@gem_ppgtt@blt-vs-render-ctxn:
>       shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023, fdo#106887) -> PASS +1
> 
>     igt@kms_color@pipe-b-degamma:
>       shard-apl:          FAIL (fdo#104782) -> PASS
> 
>     igt@kms_cursor_crc@cursor-256x256-suspend:
>       shard-apl:          FAIL (fdo#103232, fdo#103191) -> PASS
> 
>     igt@kms_cursor_crc@cursor-256x85-random:
>       shard-glk:          FAIL (fdo#103232) -> PASS
> 
>     igt@kms_cursor_crc@cursor-64x21-random:
>       shard-apl:          FAIL (fdo#103232) -> PASS +1
> 
>     igt@kms_cursor_crc@cursor-64x64-suspend:
>       shard-snb:          DMESG-WARN (fdo#102365) -> PASS
> 
>     igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
>       shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS
> 
>     igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
>       shard-apl:          FAIL (fdo#103167) -> PASS
> 
>     igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt:
>       shard-glk:          FAIL (fdo#103167) -> PASS
> 
>     igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
>       shard-kbl:          INCOMPLETE (fdo#103665) -> PASS
> 
>     igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
>       shard-apl:          FAIL (fdo#103166) -> PASS +1
> 
>     igt@kms_setmode@basic:
>       shard-apl:          FAIL (fdo#99912) -> PASS
>       shard-kbl:          FAIL (fdo#99912) -> PASS
> 
>     
>     ==== Warnings ====
> 
>     igt@kms_cursor_crc@cursor-128x42-random:
>       shard-apl:          FAIL (fdo#103232) -> DMESG-WARN (fdo#105602, fdo#103558)
> 
>     
>   fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
>   fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
>   fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
>   fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
>   fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
>   fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
>   fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
>   fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
>   fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
>   fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
>   fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
>   fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
>   fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
>   fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
>   fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   fdo#108228 https://bugs.freedesktop.org/show_bug.cgi?id=108228
>   fdo#108470 https://bugs.freedesktop.org/show_bug.cgi?id=108470
>   fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> == Participating hosts (6 -> 6) ==
> 
>   No changes in participating hosts
> 
> 
> == Build changes ==
> 
>     * Linux: CI_DRM_5062 -> Patchwork_10673
> 
>   CI_DRM_5062: 3aa71a0d803ee01605f9a3026ddd989a591a73c6 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4703: f882a542a3eb24e78e51aa6410a3a67c0efb4e97 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_10673: aed38f0dff02ec98c81e202477a88b763adfa7e0 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10673/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c3cadc09f859..ce60aefc14d7 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -455,18 +455,6 @@  static const struct intel_limit intel_limits_bxt = {
 	.p2 = { .p2_slow = 1, .p2_fast = 20 },
 };
 
-static void
-skl_wa_528(struct drm_i915_private *dev_priv, int pipe, bool enable)
-{
-	if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
-		return;
-
-	if (enable)
-		I915_WRITE(CHICKEN_PIPESL_1(pipe), HSW_FBCQ_DIS);
-	else
-		I915_WRITE(CHICKEN_PIPESL_1(pipe), 0);
-}
-
 static void
 skl_wa_clkgate(struct drm_i915_private *dev_priv, int pipe, bool enable)
 {
@@ -5286,7 +5274,6 @@  static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
 	if (needs_nv12_wa(dev_priv, old_crtc_state) &&
 	    !needs_nv12_wa(dev_priv, pipe_config)) {
 		skl_wa_clkgate(dev_priv, crtc->pipe, false);
-		skl_wa_528(dev_priv, crtc->pipe, false);
 	}
 }
 
@@ -5326,7 +5313,6 @@  static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state,
 	if (!needs_nv12_wa(dev_priv, old_crtc_state) &&
 	    needs_nv12_wa(dev_priv, pipe_config)) {
 		skl_wa_clkgate(dev_priv, crtc->pipe, true);
-		skl_wa_528(dev_priv, crtc->pipe, true);
 	}
 
 	/*