diff mbox series

[v3] drm/i915: Fix wrong escape clock divisor init for GLK

Message ID 20190712081938.14185-1-stanislav.lisovskiy@intel.com (mailing list archive)
State New, archived
Headers show
Series [v3] drm/i915: Fix wrong escape clock divisor init for GLK | expand

Commit Message

Stanislav Lisovskiy July 12, 2019, 8:19 a.m. UTC 
According to Bspec clock divisor registers in GeminiLake
should be initialized by shifting 1(<<) to amount of correspondent
divisor. While i915 was writing all this time that value as is.

Surprisingly that it by accident worked, until we met some issues
with Microtech Etab.

v2: Added Fixes tag and cc
v3: Added stable to cc as well.

Signed-off-by: stanislav.lisovskiy@intel.com
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=108826
Fixes: bcc657004841 ("drm/i915/glk: Program txesc clock divider for GLK")
Cc: Deepak M <m.deepak@intel.com>
Cc: Madhav Chauhan <madhav.chauhan@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jani Nikula Aug. 5, 2019, 7:59 a.m. UTC | #1 
On Fri, 12 Jul 2019, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: Fix wrong escape clock divisor init for GLK (rev3)
> URL   : https://patchwork.freedesktop.org/series/63505/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> bcd7871af13d drm/i915: Fix wrong escape clock divisor init for GLK
> -:43: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>'

Stan, please reply to the patch with your signed-off-by to let me push
this.

BR,
Jani.


>
> total: 0 errors, 1 warnings, 0 checks, 10 lines checked
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Stanislav Lisovskiy Aug. 5, 2019, 8:09 a.m. UTC | #2 
On Mon, 2019-08-05 at 10:59 +0300, Jani Nikula wrote:
> On Fri, 12 Jul 2019, Patchwork <patchwork@emeril.freedesktop.org>
> wrote:
> > == Series Details ==
> > 
> > Series: drm/i915: Fix wrong escape clock divisor init for GLK
> > (rev3)
> > URL   : https://patchwork.freedesktop.org/series/63505/
> > State : warning
> > 
> > == Summary ==
> > 
> > $ dim checkpatch origin/drm-tip
> > bcd7871af13d drm/i915: Fix wrong escape clock divisor init for GLK
> > -:43: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by
> > nominal patch author 'Stanislav Lisovskiy <
> > stanislav.lisovskiy@intel.com>'
> 
> Stan, please reply to the patch with your signed-off-by to let me
> push
> > this.

Need to fix this in my git commit template..

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

> 
> BR,
> Jani.
> 
> 
> > 
> > total: 0 errors, 1 warnings, 0 checks, 10 lines checked
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
>
Jani Nikula Aug. 5, 2019, 8:32 a.m. UTC | #3 
On Mon, 05 Aug 2019, "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com> wrote:
> On Mon, 2019-08-05 at 10:59 +0300, Jani Nikula wrote:
>> On Fri, 12 Jul 2019, Patchwork <patchwork@emeril.freedesktop.org>
>> wrote:
>> > == Series Details ==
>> > 
>> > Series: drm/i915: Fix wrong escape clock divisor init for GLK
>> > (rev3)
>> > URL   : https://patchwork.freedesktop.org/series/63505/
>> > State : warning
>> > 
>> > == Summary ==
>> > 
>> > $ dim checkpatch origin/drm-tip
>> > bcd7871af13d drm/i915: Fix wrong escape clock divisor init for GLK
>> > -:43: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by
>> > nominal patch author 'Stanislav Lisovskiy <
>> > stanislav.lisovskiy@intel.com>'
>> 
>> Stan, please reply to the patch with your signed-off-by to let me
>> push
>> > this.
>
> Need to fix this in my git commit template..

'git commit -s' will do the trick!

> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

Thanks, pushed with another fix:

Fixes: tag should point at a commit, for bugzilla references use
Bugzilla:.

BR,
Jani.


>
>> 
>> BR,
>> Jani.
>> 
>> 
>> > 
>> > total: 0 errors, 1 warnings, 0 checks, 10 lines checked
>> > 
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>> 
>>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
index 99cc3e2e9c2c..f016a776a39e 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
@@ -396,8 +396,8 @@  static void glk_dsi_program_esc_clock(struct drm_device *dev,
 	else
 		txesc2_div = 10;
 
-	I915_WRITE(MIPIO_TXESC_CLK_DIV1, txesc1_div & GLK_TX_ESC_CLK_DIV1_MASK);
-	I915_WRITE(MIPIO_TXESC_CLK_DIV2, txesc2_div & GLK_TX_ESC_CLK_DIV2_MASK);
+	I915_WRITE(MIPIO_TXESC_CLK_DIV1, (1 << (txesc1_div - 1)) & GLK_TX_ESC_CLK_DIV1_MASK);
+	I915_WRITE(MIPIO_TXESC_CLK_DIV2, (1 << (txesc2_div - 1)) & GLK_TX_ESC_CLK_DIV2_MASK);
 }
 
 /* Program BXT Mipi clocks and dividers */