diff mbox series

[v1] drm/i915: List modes, regardless of encoder presence

Message ID 20190906111413.7738-1-stanislav.lisovskiy@intel.com (mailing list archive)
State New, archived
Headers show
Series [v1] drm/i915: List modes, regardless of encoder presence | expand

Commit Message

Stanislav Lisovskiy Sept. 6, 2019, 11:14 a.m. UTC
In certain situations encoder might be not present for connector,
however might be useful to displat probed modes for the connector,
if any.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Lionel Landwerlin Sept. 6, 2019, 11:23 a.m. UTC | #1
On 06/09/2019 14:14, Stanislav Lisovskiy wrote:
> In certain situations encoder might be not present for connector,
> however might be useful to displat probed modes for the connector,

s/displat/display/


> if any.
>
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Tested-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 9798f27a697a..8fa0510e897f 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2574,6 +2574,10 @@ static void intel_connector_info(struct seq_file *m,
>   		   drm_get_subpixel_order_name(connector->display_info.subpixel_order));
>   	seq_printf(m, "\tCEA rev: %d\n", connector->display_info.cea_rev);
>   
> +	seq_printf(m, "\tmodes:\n");
> +	list_for_each_entry(mode, &connector->modes, head)
> +		intel_seq_print_mode(m, 2, mode);
> +
>   	if (!intel_encoder)
>   		return;
>   
> @@ -2597,10 +2601,6 @@ static void intel_connector_info(struct seq_file *m,
>   	default:
>   		break;
>   	}
> -
> -	seq_printf(m, "\tmodes:\n");
> -	list_for_each_entry(mode, &connector->modes, head)
> -		intel_seq_print_mode(m, 2, mode);
>   }
>   
>   static const char *plane_type(enum drm_plane_type type)
Stanislav Lisovskiy Sept. 6, 2019, 11:26 a.m. UTC | #2
On Fri, 2019-09-06 at 14:23 +0300, Lionel Landwerlin wrote:
> On 06/09/2019 14:14, Stanislav Lisovskiy wrote:
> > In certain situations encoder might be not present for connector,
> > however might be useful to displat probed modes for the connector,
> 
> s/displat/display/

Thanks! :)

- Stanislav
> 
> 
> > if any.
> > 
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> 
> Tested-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > ---
> >   drivers/gpu/drm/i915/i915_debugfs.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> > b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 9798f27a697a..8fa0510e897f 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2574,6 +2574,10 @@ static void intel_connector_info(struct
> > seq_file *m,
> >   		   drm_get_subpixel_order_name(connector-
> > >display_info.subpixel_order));
> >   	seq_printf(m, "\tCEA rev: %d\n", connector-
> > >display_info.cea_rev);
> >   
> > +	seq_printf(m, "\tmodes:\n");
> > +	list_for_each_entry(mode, &connector->modes, head)
> > +		intel_seq_print_mode(m, 2, mode);
> > +
> >   	if (!intel_encoder)
> >   		return;
> >   
> > @@ -2597,10 +2601,6 @@ static void intel_connector_info(struct
> > seq_file *m,
> >   	default:
> >   		break;
> >   	}
> > -
> > -	seq_printf(m, "\tmodes:\n");
> > -	list_for_each_entry(mode, &connector->modes, head)
> > -		intel_seq_print_mode(m, 2, mode);
> >   }
> >   
> >   static const char *plane_type(enum drm_plane_type type)
> 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 9798f27a697a..8fa0510e897f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2574,6 +2574,10 @@  static void intel_connector_info(struct seq_file *m,
 		   drm_get_subpixel_order_name(connector->display_info.subpixel_order));
 	seq_printf(m, "\tCEA rev: %d\n", connector->display_info.cea_rev);
 
+	seq_printf(m, "\tmodes:\n");
+	list_for_each_entry(mode, &connector->modes, head)
+		intel_seq_print_mode(m, 2, mode);
+
 	if (!intel_encoder)
 		return;
 
@@ -2597,10 +2601,6 @@  static void intel_connector_info(struct seq_file *m,
 	default:
 		break;
 	}
-
-	seq_printf(m, "\tmodes:\n");
-	list_for_each_entry(mode, &connector->modes, head)
-		intel_seq_print_mode(m, 2, mode);
 }
 
 static const char *plane_type(enum drm_plane_type type)