| Message ID | 20191104115009.15961-1-juhapekka.heikkila@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Display WA2006604312 is needed from ICL onwards | expand |
On Mon, Nov 04, 2019 at 01:50:09PM +0200, Juha-Pekka Heikkila wrote: > WA2006604312 is listed for devices from Icelake onward. The "Project" column on bspec #33450 does list EHL, however I don't see it actually listed on the dedicated EHL WA page (bspec #33451) or the TGL WA page (bspec #52890). I'm not sure which page we're supposed to trust for EHL (personally I'd trust the EHL page more than the ICL page when it comes to EHL), but it doesn't look like this should apply to TGL/gen12 as far as I can see? Matt > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index e29e80ae5698..71ac4fe5fb47 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -5981,7 +5981,7 @@ static bool needs_scalerclk_wa(struct drm_i915_private *dev_priv, > const struct intel_crtc_state *crtc_state) > { > /* Wa_2006604312:icl */ > - if (crtc_state->scaler_state.scaler_users > 0 && IS_ICELAKE(dev_priv)) > + if (crtc_state->scaler_state.scaler_users > 0 && INTEL_GEN(dev_priv) >= 11) > return true; > > return false; > -- > 2.17.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 4.11.2019 18.32, Matt Roper wrote: > On Mon, Nov 04, 2019 at 01:50:09PM +0200, Juha-Pekka Heikkila wrote: >> WA2006604312 is listed for devices from Icelake onward. > > The "Project" column on bspec #33450 does list EHL, however I don't see > it actually listed on the dedicated EHL WA page (bspec #33451) or the > TGL WA page (bspec #52890). > > I'm not sure which page we're supposed to trust for EHL (personally I'd > trust the EHL page more than the ICL page when it comes to EHL), but it > doesn't look like this should apply to TGL/gen12 as far as I can see? Hi Matt, I agree it is bit of a mess what's documented where. For Gen12 I was looking on #52887.. "I'm almost quite confident there was mention also somewhere else.." Now looking if #52890 is the current version on what's valid for gen12 you're correct and we can forget this WA. Trybot results for this patch look more useful than what's coming for this intel-gfx patch https://patchwork.freedesktop.org/series/68871/ https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5256/index.html?hosts=icl%7Ctgl In any case it doesn't seem to make any difference on test results. /Juha-Pekka >> >> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> >> --- >> drivers/gpu/drm/i915/display/intel_display.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >> index e29e80ae5698..71ac4fe5fb47 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display.c >> +++ b/drivers/gpu/drm/i915/display/intel_display.c >> @@ -5981,7 +5981,7 @@ static bool needs_scalerclk_wa(struct drm_i915_private *dev_priv, >> const struct intel_crtc_state *crtc_state) >> { >> /* Wa_2006604312:icl */ >> - if (crtc_state->scaler_state.scaler_users > 0 && IS_ICELAKE(dev_priv)) >> + if (crtc_state->scaler_state.scaler_users > 0 && INTEL_GEN(dev_priv) >= 11) >> return true; >> >> return false; >> -- >> 2.17.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index e29e80ae5698..71ac4fe5fb47 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -5981,7 +5981,7 @@ static bool needs_scalerclk_wa(struct drm_i915_private *dev_priv, const struct intel_crtc_state *crtc_state) { /* Wa_2006604312:icl */ - if (crtc_state->scaler_state.scaler_users > 0 && IS_ICELAKE(dev_priv)) + if (crtc_state->scaler_state.scaler_users > 0 && INTEL_GEN(dev_priv) >= 11) return true; return false;
WA2006604312 is listed for devices from Icelake onward. Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)