| Message ID | 20200128135425.14596-4-anshuman.gupta@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | HDCP Misc series | expand |
On 2020-01-28 at 19:24:24 +0530, Anshuman Gupta wrote: > If HDCP shim is not initialized, i915_display_info > connector info returns EINVAL without providing any debug > information. Adding a print for that will be useful for debugging. > > CC: Ramalingam C <ramalingam.c@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 0ac98e39eb75..6d913a71cbdb 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2405,7 +2405,8 @@ static void intel_dp_info(struct seq_file *m, > if (intel_connector->hdcp.shim) { > seq_puts(m, "\tHDCP version: "); > intel_hdcp_info(m, intel_connector); > - } > + } else if (!intel_dp_is_edp(intel_dp)) > + seq_puts(m, "\tHDCP shim isn't available\n"); I would prefer "HDCP shim is not initialized" for this purpose. But when this can happen on DP/HDCP connector? Either has_hdcp is false or when port is >= E. Those info might help better for debugging. Infact as we discussed in other patch, we need to check whether we need\ port limitation for <gen12. -Ram > } > > static void intel_dp_mst_info(struct seq_file *m, > @@ -2432,6 +2433,8 @@ static void intel_hdmi_info(struct seq_file *m, > if (intel_connector->hdcp.shim) { > seq_puts(m, "\tHDCP version: "); > intel_hdcp_info(m, intel_connector); > + } else { > + seq_puts(m, "\tHDCP shim isn't available\n"); > } > } > > -- > 2.24.0 >
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 0ac98e39eb75..6d913a71cbdb 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -2405,7 +2405,8 @@ static void intel_dp_info(struct seq_file *m, if (intel_connector->hdcp.shim) { seq_puts(m, "\tHDCP version: "); intel_hdcp_info(m, intel_connector); - } + } else if (!intel_dp_is_edp(intel_dp)) + seq_puts(m, "\tHDCP shim isn't available\n"); } static void intel_dp_mst_info(struct seq_file *m, @@ -2432,6 +2433,8 @@ static void intel_hdmi_info(struct seq_file *m, if (intel_connector->hdcp.shim) { seq_puts(m, "\tHDCP version: "); intel_hdcp_info(m, intel_connector); + } else { + seq_puts(m, "\tHDCP shim isn't available\n"); } }
If HDCP shim is not initialized, i915_display_info connector info returns EINVAL without providing any debug information. Adding a print for that will be useful for debugging. CC: Ramalingam C <ramalingam.c@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)