From patchwork Tue Feb 11 21:22:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Juston Li X-Patchwork-Id: 11376905 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13FDB109A for ; Tue, 11 Feb 2020 21:23:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFFAA20659 for ; Tue, 11 Feb 2020 21:23:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFFAA20659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 088BE6E393; Tue, 11 Feb 2020 21:23:11 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id A46316E393; Tue, 11 Feb 2020 21:23:09 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 13:23:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="433818947" Received: from jhli-desk1.jf.intel.com ([10.54.74.178]) by fmsmga006.fm.intel.com with ESMTP; 11 Feb 2020 13:23:07 -0800 From: Juston Li To: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Tue, 11 Feb 2020 13:22:37 -0800 Message-Id: <20200211212237.1269-2-juston.li@intel.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200211212237.1269-1-juston.li@intel.com> References: <20200211212237.1269-1-juston.li@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v6 i-g-t 2/2] tests/kms_getfb: Add getfb2 tests X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.vetter@ffwll.ch, daniels@collabora.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Daniel Stone Mirroring addfb2, add tests for the new ioctl which will return us information about framebuffers containing multiple buffers, as well as modifiers. Changes since v5: - Add documentation Changes since v4: - Remove unnecessary bo creation for getfb2-handle-closed subtest Changes since v3: - Add subtests to ensure handles aren't returned for non-root and non-master callers Changes since v1: - Add test that uses getfb2 output to call addfb2 as suggested by Ville Signed-off-by: Daniel Stone Signed-off-by: Juston Li Reviewed-by: Ville Syrjälä --- tests/kms_getfb.c | 171 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 171 insertions(+) diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c index 292679ad3eb9..c3d3c93070cd 100644 --- a/tests/kms_getfb.c +++ b/tests/kms_getfb.c @@ -40,6 +40,10 @@ #include "drm.h" #include "drm_fourcc.h" +#include "igt_device.h" + +IGT_TEST_DESCRIPTION("Tests GETFB and GETFB2 ioctls."); + static bool has_getfb_iface(int fd) { struct drm_mode_fb_cmd arg = { }; @@ -252,6 +256,167 @@ static void test_duplicate_handles(int fd) } } +static void test_getfb2(int fd) +{ + struct drm_mode_fb_cmd2 add_basic = {}; + + igt_fixture { + struct drm_mode_fb_cmd2 get = {}; + + add_basic.width = 1024; + add_basic.height = 1024; + add_basic.pixel_format = DRM_FORMAT_XRGB8888; + add_basic.pitches[0] = 1024*4; + add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024, + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL); + igt_assert(add_basic.handles[0]); + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic); + + get.fb_id = add_basic.fb_id; + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get); + igt_assert_neq_u32(get.handles[0], 0); + gem_close(fd, get.handles[0]); + } + + igt_describe("Tests error handling for a zero'd input."); + igt_subtest("getfb2-handle-zero") { + struct drm_mode_fb_cmd2 get = {}; + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT); + } + + igt_describe("Tests error handling when passing a handle that " + "has been closed."); + igt_subtest("getfb2-handle-closed") { + struct drm_mode_fb_cmd2 add = add_basic; + struct drm_mode_fb_cmd2 get = { }; + + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add); + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add.fb_id); + + get.fb_id = add.fb_id; + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT); + } + + igt_describe("Tests error handling when passing an invalid " + "handle."); + igt_subtest("getfb2-handle-not-fb") { + struct drm_mode_fb_cmd2 get = { .fb_id = get_any_prop_id(fd) }; + igt_require(get.fb_id > 0); + do_ioctl_err(fd, DRM_IOCTL_MODE_GETFB2, &get, ENOENT); + } + + igt_describe("Tests outputs are correct when retrieving a " + "CCS framebuffer."); + igt_subtest("getfb2-accept-ccs") { + struct drm_mode_fb_cmd2 add_ccs = { }; + struct drm_mode_fb_cmd2 get = { }; + int i; + + get_ccs_fb(fd, &add_ccs); + igt_require(add_ccs.fb_id != 0); + get.fb_id = add_ccs.fb_id; + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &get); + + igt_assert_eq_u32(get.width, add_ccs.width); + igt_assert_eq_u32(get.height, add_ccs.height); + igt_assert(get.flags & DRM_MODE_FB_MODIFIERS); + + for (i = 0; i < ARRAY_SIZE(get.handles); i++) { + igt_assert_eq_u32(get.pitches[i], add_ccs.pitches[i]); + igt_assert_eq_u32(get.offsets[i], add_ccs.offsets[i]); + if (add_ccs.handles[i] != 0) { + igt_assert_neq_u32(get.handles[i], 0); + igt_assert_neq_u32(get.handles[i], + add_ccs.handles[i]); + igt_assert_eq_u64(get.modifier[i], + add_ccs.modifier[i]); + } else { + igt_assert_eq_u32(get.handles[i], 0); + igt_assert_eq_u64(get.modifier[i], 0); + } + } + igt_assert_eq_u32(get.handles[0], get.handles[1]); + + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &get.fb_id); + gem_close(fd, add_ccs.handles[0]); + gem_close(fd, get.handles[0]); + } + + igt_describe("Output check by passing the output of GETFB2 " + "into ADDFB2."); + igt_subtest("getfb2-into-addfb2") { + struct drm_mode_fb_cmd2 cmd = { }; + + cmd.fb_id = add_basic.fb_id; + do_ioctl(fd, DRM_IOCTL_MODE_GETFB2, &cmd); + do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &cmd); + + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &cmd.fb_id); + gem_close(fd, cmd.handles[0]); + } + + igt_fixture { + do_ioctl(fd, DRM_IOCTL_MODE_RMFB, &add_basic.fb_id); + gem_close(fd, add_basic.handles[0]); + } +} + +static void test_handle_protection(void) { + int non_master_fd; + struct drm_mode_fb_cmd2 non_master_add = {}; + + igt_fixture { + non_master_fd = drm_open_driver(DRIVER_ANY); + + non_master_add.width = 1024; + non_master_add.height = 1024; + non_master_add.pixel_format = DRM_FORMAT_XRGB8888; + non_master_add.pitches[0] = 1024*4; + non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024, + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL); + igt_require(non_master_add.handles[0] != 0); + do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add); + } + + igt_describe("Make sure GETFB doesn't return handles if caller " + "is non-root or non-master."); + igt_subtest("getfb-handle-protection") { + struct drm_mode_fb_cmd get = { .fb_id = non_master_add.fb_id}; + + igt_fork(child, 1) { + igt_drop_root(); + + do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB, &get); + /* ioctl succeeds but handle should be 0 */ + igt_assert_eq_u32(get.handle, 0); + } + igt_waitchildren(); + } + + igt_describe("Make sure GETFB2 doesn't return handles if caller " + "is non-root or non-master."); + igt_subtest("getfb2-handle-protection") { + struct drm_mode_fb_cmd2 get = { .fb_id = non_master_add.fb_id}; + int i; + + igt_fork(child, 1) { + igt_drop_root(); + + do_ioctl(non_master_fd, DRM_IOCTL_MODE_GETFB2, &get); + /* ioctl succeeds but handles should be 0 */ + for (i = 0; i < ARRAY_SIZE(get.handles); i++) { + igt_assert_eq_u32(get.handles[i], 0); + } + } + igt_waitchildren(); + } + + igt_fixture { + do_ioctl(non_master_fd, DRM_IOCTL_MODE_RMFB, &non_master_add.fb_id); + gem_close(non_master_fd, non_master_add.handles[0]); + } +} + igt_main { int fd; @@ -267,6 +432,12 @@ igt_main igt_subtest_group test_duplicate_handles(fd); + igt_subtest_group + test_getfb2(fd); + + igt_subtest_group + test_handle_protection(); + igt_fixture close(fd); }