Message ID | 20200611233108.19205-1-clinton.a.taylor@intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/i915/gt: Implement WA_1406941453 | expand |
On Thu, Jun 11, 2020 at 04:31:08PM -0700, clinton.a.taylor@intel.com wrote: > From: Clint Taylor <clinton.a.taylor@intel.com> > > Enable HW Default flip for small PL. > > bspec: 52890 > bspec: 53508 > bspec: 53273 > > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++++++ > drivers/gpu/drm/i915/i915_reg.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index 2da366821dda..0b9091c05e06 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -628,6 +628,9 @@ static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine, > WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1, > GEN9_PREEMPT_GPGPU_LEVEL_MASK, > GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL); > + > + /* Wa_1406941453:gen12 */ > + WA_SET_BIT_MASKED(GEN10_SAMPLER_MODE, ENABLE_SMALLPL); > } > > static void > @@ -1500,6 +1503,9 @@ static void icl_whitelist_build(struct intel_engine_cs *engine) > whitelist_reg_ext(w, PS_INVOCATION_COUNT, > RING_FORCE_TO_NONPRIV_ACCESS_RD | > RING_FORCE_TO_NONPRIV_RANGE_4); > + > + /* Wa_1406941453:gen12 */ > + whitelist_reg(w, GEN10_SAMPLER_MODE); > break; > > case VIDEO_DECODE_CLASS: > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 19e1fed198c3..fbb095a94b3a 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -9223,6 +9223,7 @@ enum { > #define GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC (1 << 7) > > #define GEN10_SAMPLER_MODE _MMIO(0xE18C) > +#define ENABLE_SMALLPL REG_BIT(15) > #define GEN11_SAMPLER_ENABLE_HEADLESS_MSG REG_BIT(5) > > /* IVYBRIDGE DPF */ > -- > 2.26.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Jun 12, 2020 at 12:04:35AM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/gt: Implement WA_1406941453 > URL : https://patchwork.freedesktop.org/series/78243/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_8618 -> Patchwork_17931 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_17931 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_17931, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/index.html > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_17931: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@runner@aborted: > - fi-bdw-5557u: NOTRUN -> [FAIL][1] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-bdw-5557u/igt@runner@aborted.html Lakshmi - this failure isn't related - can you re-report? Thanks! -James > > > Known issues > ------------ > > Here are the changes found in Patchwork_17931 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_exec_suspend@basic-s0: > - fi-tgl-u2: [PASS][2] -> [FAIL][3] ([i915#1888]) > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html > > * igt@gem_sync@basic-all: > - fi-icl-guc: [PASS][4] -> [DMESG-WARN][5] ([i915#1982]) > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-icl-guc/igt@gem_sync@basic-all.html > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-icl-guc/igt@gem_sync@basic-all.html > > * igt@i915_module_load@reload: > - fi-tgl-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#1982]) > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-tgl-u2/igt@i915_module_load@reload.html > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-tgl-u2/igt@i915_module_load@reload.html > > * igt@i915_pm_rpm@basic-pci-d3-state: > - fi-bsw-kefka: [PASS][8] -> [DMESG-WARN][9] ([i915#1982]) > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html > > * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: > - fi-icl-u2: [PASS][10] -> [DMESG-WARN][11] ([i915#1982]) +1 similar issue > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html > > > #### Possible fixes #### > > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: > - fi-byt-j1900: [DMESG-WARN][12] ([i915#1982]) -> [PASS][13] > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html > > * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: > - fi-tgl-u2: [DMESG-WARN][14] ([i915#402]) -> [PASS][15] > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html > > > #### Warnings #### > > * igt@gem_exec_suspend@basic-s0: > - fi-kbl-x1275: [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][17] ([i915#62] / [i915#92]) +2 similar issues > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html > > * igt@kms_flip@basic-flip-vs-modeset@a-dp1: > - fi-kbl-x1275: [DMESG-WARN][18] ([i915#62] / [i915#92]) -> [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html > > > [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 > [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 > [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 > [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 > [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 > [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 > > > Participating hosts (50 -> 42) > ------------------------------ > > Missing (8): fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus > > > Build changes > ------------- > > * Linux: CI_DRM_8618 -> Patchwork_17931 > > CI-20190529: 20190529 > CI_DRM_8618: 88841e30e7f8c60ff464be277e5b8fef49ebaea0 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5703: c33471b4aa0a0ae9dd42202048e7037a661e0574 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_17931: 39466c9ac72e20913b60ada9fdf53b78e4a6f70b @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > 39466c9ac72e drm/i915/gt: Implement WA_1406941453 > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/index.html > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re-reported. -----Original Message----- From: Ausmus, James <james.ausmus@intel.com> Sent: Wednesday, June 24, 2020 9:32 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Cc: Taylor, Clinton A <clinton.a.taylor@intel.com> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Implement WA_1406941453 On Fri, Jun 12, 2020 at 12:04:35AM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915/gt: Implement WA_1406941453 > URL : https://patchwork.freedesktop.org/series/78243/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_8618 -> Patchwork_17931 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_17931 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_17931, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/index.html > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_17931: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@runner@aborted: > - fi-bdw-5557u: NOTRUN -> [FAIL][1] > [1]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-bdw-5557u/ > igt@runner@aborted.html Lakshmi - this failure isn't related - can you re-report? Thanks! -James > > > Known issues > ------------ > > Here are the changes found in Patchwork_17931 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_exec_suspend@basic-s0: > - fi-tgl-u2: [PASS][2] -> [FAIL][3] ([i915#1888]) > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html > [3]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-tgl-u2/igt > @gem_exec_suspend@basic-s0.html > > * igt@gem_sync@basic-all: > - fi-icl-guc: [PASS][4] -> [DMESG-WARN][5] ([i915#1982]) > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-icl-guc/igt@gem_sync@basic-all.html > [5]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-icl-guc/ig > t@gem_sync@basic-all.html > > * igt@i915_module_load@reload: > - fi-tgl-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#1982]) > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-tgl-u2/igt@i915_module_load@reload.html > [7]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-tgl-u2/igt > @i915_module_load@reload.html > > * igt@i915_pm_rpm@basic-pci-d3-state: > - fi-bsw-kefka: [PASS][8] -> [DMESG-WARN][9] ([i915#1982]) > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html > [9]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-bsw-kefka/ > igt@i915_pm_rpm@basic-pci-d3-state.html > > * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: > - fi-icl-u2: [PASS][10] -> [DMESG-WARN][11] ([i915#1982]) +1 similar issue > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html > [11]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-icl-u2/igt > @kms_flip@basic-flip-vs-wf_vblank@b-edp1.html > > > #### Possible fixes #### > > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: > - fi-byt-j1900: [DMESG-WARN][12] ([i915#1982]) -> [PASS][13] > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html > [13]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-byt-j1900/ > igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html > > * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: > - fi-tgl-u2: [DMESG-WARN][14] ([i915#402]) -> [PASS][15] > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html > [15]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-tgl-u2/igt > @kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html > > > #### Warnings #### > > * igt@gem_exec_suspend@basic-s0: > - fi-kbl-x1275: [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][17] ([i915#62] / [i915#92]) +2 similar issues > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html > [17]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-kbl-x1275/ > igt@gem_exec_suspend@basic-s0.html > > * igt@kms_flip@basic-flip-vs-modeset@a-dp1: > - fi-kbl-x1275: [DMESG-WARN][18] ([i915#62] / [i915#92]) -> [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8618/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html > [19]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/fi-kbl-x1275/ > igt@kms_flip@basic-flip-vs-modeset@a-dp1.html > > > [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 > [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 > [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 > [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 > [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 > [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 > > > Participating hosts (50 -> 42) > ------------------------------ > > Missing (8): fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus > > > Build changes > ------------- > > * Linux: CI_DRM_8618 -> Patchwork_17931 > > CI-20190529: 20190529 > CI_DRM_8618: 88841e30e7f8c60ff464be277e5b8fef49ebaea0 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5703: c33471b4aa0a0ae9dd42202048e7037a661e0574 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_17931: 39466c9ac72e20913b60ada9fdf53b78e4a6f70b @ > git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > 39466c9ac72e drm/i915/gt: Implement WA_1406941453 > > == Logs == > > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17931/index.html > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 2da366821dda..0b9091c05e06 100644 --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -628,6 +628,9 @@ static void tgl_ctx_workarounds_init(struct intel_engine_cs *engine, WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1, GEN9_PREEMPT_GPGPU_LEVEL_MASK, GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL); + + /* Wa_1406941453:gen12 */ + WA_SET_BIT_MASKED(GEN10_SAMPLER_MODE, ENABLE_SMALLPL); } static void @@ -1500,6 +1503,9 @@ static void icl_whitelist_build(struct intel_engine_cs *engine) whitelist_reg_ext(w, PS_INVOCATION_COUNT, RING_FORCE_TO_NONPRIV_ACCESS_RD | RING_FORCE_TO_NONPRIV_RANGE_4); + + /* Wa_1406941453:gen12 */ + whitelist_reg(w, GEN10_SAMPLER_MODE); break; case VIDEO_DECODE_CLASS: diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 19e1fed198c3..fbb095a94b3a 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -9223,6 +9223,7 @@ enum { #define GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC (1 << 7) #define GEN10_SAMPLER_MODE _MMIO(0xE18C) +#define ENABLE_SMALLPL REG_BIT(15) #define GEN11_SAMPLER_ENABLE_HEADLESS_MSG REG_BIT(5) /* IVYBRIDGE DPF */