From patchwork Sun Jul 26 13:03:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Modem, Bhanuprakash" X-Patchwork-Id: 11685513 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C08AB722 for ; Sun, 26 Jul 2020 05:09:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8D0020715 for ; Sun, 26 Jul 2020 05:09:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D0020715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DF6C6E092; Sun, 26 Jul 2020 05:08:59 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F7A86E088 for ; Sun, 26 Jul 2020 05:08:56 +0000 (UTC) IronPort-SDR: fCWU4vWwn0t0WR/+AxYg3EyFOkujIzu3psP/Cskying91NfE9eyg/VPuaZULMafYCmlzEJLwEZ 9kGB/PBj6obg== X-IronPort-AV: E=McAfee;i="6000,8403,9693"; a="150054555" X-IronPort-AV: E=Sophos;i="5.75,397,1589266800"; d="scan'208";a="150054555" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2020 22:08:56 -0700 IronPort-SDR: eRp69P1u4ZOenSKYxEx32Z8WWGQ9XFHsVBEdn3KKJmHi5mUb9x7elreWd9CWRCfTSRPm7llbIN ERip1H9adCIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,397,1589266800"; d="scan'208";a="285334902" Received: from bhanu-nuc8i7beh.iind.intel.com ([10.145.162.210]) by orsmga003.jf.intel.com with ESMTP; 25 Jul 2020 22:08:54 -0700 From: Bhanuprakash Modem To: bhanuprakash.modem@intel.com, intel-gfx@lists.freedesktop.org Date: Sun, 26 Jul 2020 18:33:59 +0530 Message-Id: <20200726130400.10160-2-bhanuprakash.modem@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200726130400.10160-1-bhanuprakash.modem@intel.com> References: <20200726130400.10160-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 1/2] i915/debug: Expose crtc dither state via debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" [Why] It's useful to know the dithering state for IGT testing. [How] Expose the dithering state for the crtc via a debugfs file "dither". Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither Cc: Uma Shankar Signed-off-by: Bhanuprakash Modem --- drivers/gpu/drm/i915/i915_debugfs.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 784219962193..7174fce05e6e 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1650,13 +1650,30 @@ static const struct i915_debugfs_files { #endif }; +static int dither_state_show(struct seq_file *m, void *data) +{ + struct intel_crtc *crtc = to_intel_crtc(m->private); + struct intel_crtc_state *crtc_state = to_intel_crtc_state(crtc->base.state); + + seq_printf(m, "Dither: %u\n", crtc_state->dither); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(dither_state); + void i915_debugfs_register(struct drm_i915_private *dev_priv) { struct drm_minor *minor = dev_priv->drm.primary; + struct drm_device *dev = &dev_priv->drm; + struct drm_crtc *crtc; int i; i915_debugfs_params(dev_priv); + drm_for_each_crtc(crtc, dev) + debugfs_create_file("dither", S_IRUGO, crtc->debugfs_entry, crtc, + &dither_state_fops); + debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root, to_i915(minor->dev), &i915_forcewake_fops); for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {