From patchwork Tue Aug 25 10:26:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Lee, Shawn C" X-Patchwork-Id: 11735489 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70347722 for ; Tue, 25 Aug 2020 10:27:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 584722068F for ; Tue, 25 Aug 2020 10:27:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 584722068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94ECE6E8DB; Tue, 25 Aug 2020 10:27:41 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E65D6E8D4 for ; Tue, 25 Aug 2020 10:27:40 +0000 (UTC) IronPort-SDR: AQUL2L65K/neZgIZnOj2reUlRdmDdnBU0IK0t5VI1ZwODwDxHXgeYM4JA4jOzMZ5ueU57BPnSL PEszGgfno1BQ== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="143856646" X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="143856646" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 03:27:39 -0700 IronPort-SDR: TPnUYI5JD5rLGSHFOlRe/8x896EdF+tODKj1ooiJgizGCIYYicvj+WrNkOJKOqvJ3usFZJ6k1/ g3GKx+e0XtRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="474291230" Received: from shawnle1-build-machine.itwn.intel.com ([10.5.253.9]) by orsmga005.jf.intel.com with ESMTP; 25 Aug 2020 03:27:38 -0700 From: Lee Shawn C To: intel-gfx@lists.freedesktop.org Date: Tue, 25 Aug 2020 18:26:00 +0800 Message-Id: <20200825102600.27779-1-shawn.c.lee@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915/fbc: Disable fbc with VT-d also with cometlake X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: William Tseng , Jani Nikula Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Both VT-d and FBC enabled that caused display flicker issue very randomly. According to sighting report, it recommend to disable FBC to workaround this issue. Cc: Ville Syrjälä Cc: Rodrigo Vivi Cc: Mika Kuoppala Cc: Jani Nikula Cc: William Tseng Signed-off-by: Lee Shawn C --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index 135f5e8a4d70..327af428d73f 100644 --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++ b/drivers/gpu/drm/i915/display/intel_fbc.c @@ -1443,7 +1443,8 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) { /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ if (intel_vtd_active() && - (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) { + (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) || + IS_COMETLAKE(dev_priv))) { drm_info(&dev_priv->drm, "Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n"); return true;