diff mbox series

[i-g-t,v6,12/24] tests/core_hotunplug: Fail subtests on device close errors

Message ID 20200911103039.4574-13-janusz.krzysztofik@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series tests/core_hotunplug: Fixes and enhancements | expand

Commit Message

Janusz Krzysztofik Sept. 11, 2020, 10:30 a.m. UTC 
Since health checks are now run from follow-up fixture sections, it is
safe to fail subtests without the need to abort the test execution.  Do
that on device close errors instead of just emitting warnings.

v2: Rebase only.
v3: Refresh.
v4: Refresh.

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
---
 tests/core_hotunplug.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 7fc6df688..d31faf215 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -158,6 +158,7 @@  static void device_unplug(struct hotunplug *priv, const char *prefix)
 	igt_reset_timeout();
 
 	priv->fd.sysfs_dev = close_sysfs(priv->fd.sysfs_dev);
+	igt_assert_eq(priv->fd.sysfs_dev, -1);
 }
 
 /* Re-discover the device by rescanning its bus */
@@ -279,6 +280,7 @@  static void hotunbind_lateclose(struct hotunplug *priv)
 	driver_bind(priv);
 
 	priv->fd.drm = close_device(priv->fd.drm, "late ", "unbound ");
+	igt_assert_eq(priv->fd.drm, -1);
 
 	healthcheck(priv);
 }
@@ -293,6 +295,7 @@  static void hotunplug_lateclose(struct hotunplug *priv)
 	bus_rescan(priv);
 
 	priv->fd.drm = close_device(priv->fd.drm, "late ", "removed ");
+	igt_assert_eq(priv->fd.drm, -1);
 
 	healthcheck(priv);
 }