diff mbox series

[2/3] fbcon: Drop EXPORT_SYMBOL

Message ID 20201029101428.4058311-2-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show
Series [1/3] fbcon: Disable accelerated scrolling | expand

Commit Message

Daniel Vetter Oct. 29, 2020, 10:14 a.m. UTC
Every since

commit 6104c37094e729f3d4ce65797002112735d49cd1
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Aug 1 17:32:07 2017 +0200

    fbcon: Make fbcon a built-time depency for fbdev

these are no longer distinct loadable modules, so exporting symbols is
kinda pointless.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Helge Deller <deller@gmx.de>
Cc: Peilin Ye <yepeilin.cs@gmail.com>
---
 drivers/video/fbdev/core/bitblit.c      | 3 ---
 drivers/video/fbdev/core/fbcon_ccw.c    | 1 -
 drivers/video/fbdev/core/fbcon_cw.c     | 1 -
 drivers/video/fbdev/core/fbcon_rotate.c | 1 -
 drivers/video/fbdev/core/fbcon_ud.c     | 1 -
 drivers/video/fbdev/core/softcursor.c   | 2 --
 drivers/video/fbdev/core/tileblit.c     | 2 --
 7 files changed, 11 deletions(-)

Comments

Thomas Zimmermann Oct. 29, 2020, 7:15 p.m. UTC | #1
Am 29.10.20 um 11:14 schrieb Daniel Vetter:
> Every since
> 
> commit 6104c37094e729f3d4ce65797002112735d49cd1
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Tue Aug 1 17:32:07 2017 +0200
> 
>     fbcon: Make fbcon a built-time depency for fbdev
> 
> these are no longer distinct loadable modules, so exporting symbols is
> kinda pointless.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Peilin Ye <yepeilin.cs@gmail.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>  drivers/video/fbdev/core/bitblit.c      | 3 ---
>  drivers/video/fbdev/core/fbcon_ccw.c    | 1 -
>  drivers/video/fbdev/core/fbcon_cw.c     | 1 -
>  drivers/video/fbdev/core/fbcon_rotate.c | 1 -
>  drivers/video/fbdev/core/fbcon_ud.c     | 1 -
>  drivers/video/fbdev/core/softcursor.c   | 2 --
>  drivers/video/fbdev/core/tileblit.c     | 2 --
>  7 files changed, 11 deletions(-)
> 
> diff --git a/drivers/video/fbdev/core/bitblit.c b/drivers/video/fbdev/core/bitblit.c
> index 9725ecd1255b..f98e8f298bc1 100644
> --- a/drivers/video/fbdev/core/bitblit.c
> +++ b/drivers/video/fbdev/core/bitblit.c
> @@ -404,6 +404,3 @@ void fbcon_set_bitops(struct fbcon_ops *ops)
>  	if (ops->rotate)
>  		fbcon_set_rotate(ops);
>  }
> -
> -EXPORT_SYMBOL(fbcon_set_bitops);
> -
> diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/core/fbcon_ccw.c
> index bbd869efd03b..9cd2c4b05c32 100644
> --- a/drivers/video/fbdev/core/fbcon_ccw.c
> +++ b/drivers/video/fbdev/core/fbcon_ccw.c
> @@ -409,4 +409,3 @@ void fbcon_rotate_ccw(struct fbcon_ops *ops)
>  	ops->cursor = ccw_cursor;
>  	ops->update_start = ccw_update_start;
>  }
> -EXPORT_SYMBOL(fbcon_rotate_ccw);
> diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core/fbcon_cw.c
> index a34cbe8e9874..88d89fad3f05 100644
> --- a/drivers/video/fbdev/core/fbcon_cw.c
> +++ b/drivers/video/fbdev/core/fbcon_cw.c
> @@ -392,4 +392,3 @@ void fbcon_rotate_cw(struct fbcon_ops *ops)
>  	ops->cursor = cw_cursor;
>  	ops->update_start = cw_update_start;
>  }
> -EXPORT_SYMBOL(fbcon_rotate_cw);
> diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/core/fbcon_rotate.c
> index ac72d4f85f7d..df6b469aa2c2 100644
> --- a/drivers/video/fbdev/core/fbcon_rotate.c
> +++ b/drivers/video/fbdev/core/fbcon_rotate.c
> @@ -110,4 +110,3 @@ void fbcon_set_rotate(struct fbcon_ops *ops)
>  		break;
>  	}
>  }
> -EXPORT_SYMBOL(fbcon_set_rotate);
> diff --git a/drivers/video/fbdev/core/fbcon_ud.c b/drivers/video/fbdev/core/fbcon_ud.c
> index 199cbc7abe35..8d5e66b1bdfb 100644
> --- a/drivers/video/fbdev/core/fbcon_ud.c
> +++ b/drivers/video/fbdev/core/fbcon_ud.c
> @@ -436,4 +436,3 @@ void fbcon_rotate_ud(struct fbcon_ops *ops)
>  	ops->cursor = ud_cursor;
>  	ops->update_start = ud_update_start;
>  }
> -EXPORT_SYMBOL(fbcon_rotate_ud);
> diff --git a/drivers/video/fbdev/core/softcursor.c b/drivers/video/fbdev/core/softcursor.c
> index fc93f254498e..29e5b21cf373 100644
> --- a/drivers/video/fbdev/core/softcursor.c
> +++ b/drivers/video/fbdev/core/softcursor.c
> @@ -74,5 +74,3 @@ int soft_cursor(struct fb_info *info, struct fb_cursor *cursor)
>  	info->fbops->fb_imageblit(info, image);
>  	return 0;
>  }
> -
> -EXPORT_SYMBOL(soft_cursor);
> diff --git a/drivers/video/fbdev/core/tileblit.c b/drivers/video/fbdev/core/tileblit.c
> index 628fe5e010c0..7539ae9040f8 100644
> --- a/drivers/video/fbdev/core/tileblit.c
> +++ b/drivers/video/fbdev/core/tileblit.c
> @@ -151,5 +151,3 @@ void fbcon_set_tileops(struct vc_data *vc, struct fb_info *info)
>  		info->tileops->fb_settile(info, &map);
>  	}
>  }
> -
> -EXPORT_SYMBOL(fbcon_set_tileops);
>
diff mbox series

Patch

diff --git a/drivers/video/fbdev/core/bitblit.c b/drivers/video/fbdev/core/bitblit.c
index 9725ecd1255b..f98e8f298bc1 100644
--- a/drivers/video/fbdev/core/bitblit.c
+++ b/drivers/video/fbdev/core/bitblit.c
@@ -404,6 +404,3 @@  void fbcon_set_bitops(struct fbcon_ops *ops)
 	if (ops->rotate)
 		fbcon_set_rotate(ops);
 }
-
-EXPORT_SYMBOL(fbcon_set_bitops);
-
diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/core/fbcon_ccw.c
index bbd869efd03b..9cd2c4b05c32 100644
--- a/drivers/video/fbdev/core/fbcon_ccw.c
+++ b/drivers/video/fbdev/core/fbcon_ccw.c
@@ -409,4 +409,3 @@  void fbcon_rotate_ccw(struct fbcon_ops *ops)
 	ops->cursor = ccw_cursor;
 	ops->update_start = ccw_update_start;
 }
-EXPORT_SYMBOL(fbcon_rotate_ccw);
diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core/fbcon_cw.c
index a34cbe8e9874..88d89fad3f05 100644
--- a/drivers/video/fbdev/core/fbcon_cw.c
+++ b/drivers/video/fbdev/core/fbcon_cw.c
@@ -392,4 +392,3 @@  void fbcon_rotate_cw(struct fbcon_ops *ops)
 	ops->cursor = cw_cursor;
 	ops->update_start = cw_update_start;
 }
-EXPORT_SYMBOL(fbcon_rotate_cw);
diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/core/fbcon_rotate.c
index ac72d4f85f7d..df6b469aa2c2 100644
--- a/drivers/video/fbdev/core/fbcon_rotate.c
+++ b/drivers/video/fbdev/core/fbcon_rotate.c
@@ -110,4 +110,3 @@  void fbcon_set_rotate(struct fbcon_ops *ops)
 		break;
 	}
 }
-EXPORT_SYMBOL(fbcon_set_rotate);
diff --git a/drivers/video/fbdev/core/fbcon_ud.c b/drivers/video/fbdev/core/fbcon_ud.c
index 199cbc7abe35..8d5e66b1bdfb 100644
--- a/drivers/video/fbdev/core/fbcon_ud.c
+++ b/drivers/video/fbdev/core/fbcon_ud.c
@@ -436,4 +436,3 @@  void fbcon_rotate_ud(struct fbcon_ops *ops)
 	ops->cursor = ud_cursor;
 	ops->update_start = ud_update_start;
 }
-EXPORT_SYMBOL(fbcon_rotate_ud);
diff --git a/drivers/video/fbdev/core/softcursor.c b/drivers/video/fbdev/core/softcursor.c
index fc93f254498e..29e5b21cf373 100644
--- a/drivers/video/fbdev/core/softcursor.c
+++ b/drivers/video/fbdev/core/softcursor.c
@@ -74,5 +74,3 @@  int soft_cursor(struct fb_info *info, struct fb_cursor *cursor)
 	info->fbops->fb_imageblit(info, image);
 	return 0;
 }
-
-EXPORT_SYMBOL(soft_cursor);
diff --git a/drivers/video/fbdev/core/tileblit.c b/drivers/video/fbdev/core/tileblit.c
index 628fe5e010c0..7539ae9040f8 100644
--- a/drivers/video/fbdev/core/tileblit.c
+++ b/drivers/video/fbdev/core/tileblit.c
@@ -151,5 +151,3 @@  void fbcon_set_tileops(struct vc_data *vc, struct fb_info *info)
 		info->tileops->fb_settile(info, &map);
 	}
 }
-
-EXPORT_SYMBOL(fbcon_set_tileops);