diff mbox series

[v9,05/12] drm/i915/display: Nuke bogus lspcon check

Message ID 20201103152834.12727-6-uma.shankar@intel.com (mailing list archive)
State New, archived
Headers show
Series [v9,01/12] drm/i915/display: Add HDR Capability detection for LSPCON | expand

Commit Message

Shankar, Uma Nov. 3, 2020, 3:28 p.m. UTC
Dropped a irrelevant lspcon check from intel_hdmi_add_properties
function.

Suggested-by: Ville Syrjälä"  <ville.syrjala@linux.intel.com>
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Ville Syrjälä Nov. 25, 2020, 4:29 p.m. UTC | #1
On Tue, Nov 03, 2020 at 08:58:27PM +0530, Uma Shankar wrote:
> Dropped a irrelevant lspcon check from intel_hdmi_add_properties
> function.
> 
> Suggested-by: Ville Syrjälä"  <ville.syrjala@linux.intel.com>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 8e4b820b715a..f1a927cdf798 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2950,20 +2950,12 @@ static void
>  intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
> -	struct intel_digital_port *dig_port =
> -				hdmi_to_dig_port(intel_hdmi);
>  
>  	intel_attach_force_audio_property(connector);
>  	intel_attach_broadcast_rgb_property(connector);
>  	intel_attach_aspect_ratio_property(connector);
>  
> -	/*
> -	 * Attach Colorspace property for Non LSPCON based device
> -	 * ToDo: This needs to be extended for LSPCON implementation
> -	 * as well. Will be implemented separately.
> -	 */
> -	if (!dig_port->lspcon.active)
> -		intel_attach_colorspace_property(connector);
> +	intel_attach_colorspace_property(connector);
>  
>  	drm_connector_attach_content_type_property(connector);
>  
> -- 
> 2.26.2
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 8e4b820b715a..f1a927cdf798 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2950,20 +2950,12 @@  static void
 intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->dev);
-	struct intel_digital_port *dig_port =
-				hdmi_to_dig_port(intel_hdmi);
 
 	intel_attach_force_audio_property(connector);
 	intel_attach_broadcast_rgb_property(connector);
 	intel_attach_aspect_ratio_property(connector);
 
-	/*
-	 * Attach Colorspace property for Non LSPCON based device
-	 * ToDo: This needs to be extended for LSPCON implementation
-	 * as well. Will be implemented separately.
-	 */
-	if (!dig_port->lspcon.active)
-		intel_attach_colorspace_property(connector);
+	intel_attach_colorspace_property(connector);
 
 	drm_connector_attach_content_type_property(connector);