diff mbox series

[v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Message ID 20210127065034.2501119-1-juston.li@intel.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST | expand

Commit Message

Juston Li Jan. 27, 2021, 6:50 a.m. UTC 
From: Sean Paul <seanpaul@chromium.org>

The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS
check, it was always a nice-to-have. After deploying this across various
devices, we've determined that some MST bridge chips do not properly
support this call for HDCP 1.4 (namely Synaptics and Realtek).

I had considered creating a quirk for this, but I think it's more
prudent to just disable the check entirely since I don't have an idea
how widespread support is.

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210106223909.34476-1-sean@poorly.run #v1

Changes in v2:
-Rebased on -tip
---
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

Gupta, Anshuman Jan. 27, 2021, 11:14 a.m. UTC | #1 
Hi Lakshmi ,
Below CI failure is a Core failures, which has failed BAT results.
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-bxt-dsi/igt@i915_selftest@live@hangcheck.html#dmesg-warnings426
Could you please re-report results.
Thanks ,
Anshuman Gupta.

From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Patchwork
Sent: Wednesday, January 27, 2021 1:16 PM
To: Li, Juston <juston.li@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Patch Details
Series:

series starting with [v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

URL:

https://patchwork.freedesktop.org/series/86325/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/index.html

CI Bug Log - changes from CI_DRM_9686 -> Patchwork_19513
Summary

FAILURE

Serious unknown changes coming with Patchwork_19513 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19513, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/index.html

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_19513:

IGT changes
Possible regressions

  *   igt@i915_selftest@live@hangcheck:

     *   fi-bxt-dsi: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-bxt-dsi/igt@i915_selftest@live@hangcheck.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-bxt-dsi/igt@i915_selftest@live@hangcheck.html>

Known issues

Here are the changes found in Patchwork_19513 that come from known issues:

IGT changes
Issues hit

  *   igt@gem_mmap_gtt@basic:

     *   fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-tgl-y/igt@gem_mmap_gtt@basic.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-tgl-y/igt@gem_mmap_gtt@basic.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) +1 similar issue

  *   igt@runner@aborted:

     *   fi-bxt-dsi: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-bxt-dsi/igt@runner@aborted.html> (i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426>)

Possible fixes

  *   igt@gem_exec_create@basic:

     *   fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-tgl-y/igt@gem_exec_create@basic.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-tgl-y/igt@gem_exec_create@basic.html> +1 similar issue

Participating hosts (44 -> 39)

Missing (5): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-2

Build changes

  *   Linux: CI_DRM_9686 -> Patchwork_19513

CI-20190529: 20190529
CI_DRM_9686: 8de0436dc0e777bbd5490d56134a838da4c19121 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5973: 7ae3d0d68e6bf4c5e404c87b570773d1b3173d47 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19513: cf90167ec8d878cf7739b728e49fd65c5203ac32 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

cf90167ec8d8 drm/i915/hdcp: disable the QSES check for HDCP2.2 over MST
0f5367aacba6 drm/i915/hdcp: read RxInfo once when reading Send_Pairing_Info
c03a6673e642 drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()
69e116124dea drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST
Vudum, Lakshminarayana Jan. 27, 2021, 5:53 p.m. UTC | #2 
Re-reported.

From: Gupta, Anshuman <anshuman.gupta@intel.com>
Sent: Wednesday, January 27, 2021 3:14 AM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Cc: Li, Juston <juston.li@intel.com>
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Hi Lakshmi ,
Below CI failure is a Core failures, which has failed BAT results.
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-bxt-dsi/igt@i915_selftest@live@hangcheck.html#dmesg-warnings426
Could you please re-report results.
Thanks ,
Anshuman Gupta.

From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org<mailto:intel-gfx-bounces@lists.freedesktop.org>> On Behalf Of Patchwork
Sent: Wednesday, January 27, 2021 1:16 PM
To: Li, Juston <juston.li@intel.com<mailto:juston.li@intel.com>>
Cc: intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org>
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

Patch Details
Series:

series starting with [v2,1/4] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

URL:

https://patchwork.freedesktop.org/series/86325/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/index.html

CI Bug Log - changes from CI_DRM_9686 -> Patchwork_19513
Summary

FAILURE

Serious unknown changes coming with Patchwork_19513 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19513, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/index.html

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_19513:

IGT changes
Possible regressions

  *   igt@i915_selftest@live@hangcheck:

     *   fi-bxt-dsi: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-bxt-dsi/igt@i915_selftest@live@hangcheck.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-bxt-dsi/igt@i915_selftest@live@hangcheck.html>

Known issues

Here are the changes found in Patchwork_19513 that come from known issues:

IGT changes
Issues hit

  *   igt@gem_mmap_gtt@basic:

     *   fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-tgl-y/igt@gem_mmap_gtt@basic.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-tgl-y/igt@gem_mmap_gtt@basic.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) +1 similar issue

  *   igt@runner@aborted:

     *   fi-bxt-dsi: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-bxt-dsi/igt@runner@aborted.html> (i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426>)

Possible fixes

  *   igt@gem_exec_create@basic:

     *   fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-tgl-y/igt@gem_exec_create@basic.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19513/fi-tgl-y/igt@gem_exec_create@basic.html> +1 similar issue

Participating hosts (44 -> 39)

Missing (5): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-2

Build changes

  *   Linux: CI_DRM_9686 -> Patchwork_19513

CI-20190529: 20190529
CI_DRM_9686: 8de0436dc0e777bbd5490d56134a838da4c19121 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5973: 7ae3d0d68e6bf4c5e404c87b570773d1b3173d47 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19513: cf90167ec8d878cf7739b728e49fd65c5203ac32 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

cf90167ec8d8 drm/i915/hdcp: disable the QSES check for HDCP2.2 over MST
0f5367aacba6 drm/i915/hdcp: read RxInfo once when reading Send_Pairing_Info
c03a6673e642 drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()
69e116124dea drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index f372e25edab4..4dba5bb15af5 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -722,16 +722,6 @@  static bool intel_dp_mst_get_qses_status(struct intel_digital_port *dig_port,
 	return reply.auth_completed && reply.encryption_enabled;
 }
 
-static
-bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
-				  struct intel_connector *connector)
-{
-	if (!intel_dp_hdcp_check_link(dig_port, connector))
-		return false;
-
-	return intel_dp_mst_get_qses_status(dig_port, connector);
-}
-
 static int
 intel_dp_mst_hdcp2_stream_encryption(struct intel_connector *connector,
 				     bool enable)
@@ -805,7 +795,7 @@  static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {
 	.read_v_prime_part = intel_dp_hdcp_read_v_prime_part,
 	.toggle_signalling = intel_dp_hdcp_toggle_signalling,
 	.stream_encryption = intel_dp_mst_hdcp_stream_encryption,
-	.check_link = intel_dp_mst_hdcp_check_link,
+	.check_link = intel_dp_hdcp_check_link,
 	.hdcp_capable = intel_dp_hdcp_capable,
 	.write_2_2_msg = intel_dp_hdcp2_write_msg,
 	.read_2_2_msg = intel_dp_hdcp2_read_msg,