diff mbox series

i915/perf: Drop the check for report reason in OA

Message ID 20210210190106.8586-1-umesh.nerlige.ramappa@intel.com (mailing list archive)
State New, archived
Headers show
Series i915/perf: Drop the check for report reason in OA | expand

Commit Message

Umesh Nerlige Ramappa Feb. 10, 2021, 7:01 p.m. UTC 
After fixing the OA_TAIL_PTR corruption, there are no more reports with
reason field of zero. Drop the check for report reason.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 drivers/gpu/drm/i915/i915_perf.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Lionel Landwerlin Feb. 11, 2021, 11:01 a.m. UTC | #1 
On 10/02/2021 21:01, Umesh Nerlige Ramappa wrote:
> After fixing the OA_TAIL_PTR corruption, there are no more reports with
> reason field of zero. Drop the check for report reason.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>


I thought I push this patch already :|

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


> ---
>   drivers/gpu/drm/i915/i915_perf.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 93f3e2c5c89a..c15bead2dac7 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -725,11 +725,6 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
>   			  (IS_GEN(stream->perf->i915, 12) ?
>   			   OAREPORT_REASON_MASK_EXTENDED :
>   			   OAREPORT_REASON_MASK));
> -		if (reason == 0) {
> -			if (__ratelimit(&stream->perf->spurious_report_rs))
> -				DRM_NOTE("Skipping spurious, invalid OA report\n");
> -			continue;
> -		}
>   
>   		ctx_id = report32[2] & stream->specific_ctx_id_mask;
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 93f3e2c5c89a..c15bead2dac7 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -725,11 +725,6 @@  static int gen8_append_oa_reports(struct i915_perf_stream *stream,
 			  (IS_GEN(stream->perf->i915, 12) ?
 			   OAREPORT_REASON_MASK_EXTENDED :
 			   OAREPORT_REASON_MASK));
-		if (reason == 0) {
-			if (__ratelimit(&stream->perf->spurious_report_rs))
-				DRM_NOTE("Skipping spurious, invalid OA report\n");
-			continue;
-		}
 
 		ctx_id = report32[2] & stream->specific_ctx_id_mask;