From patchwork Thu Apr 1 14:36:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 12178175 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32682C43460 for ; Thu, 1 Apr 2021 14:37:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE8306120F for ; Thu, 1 Apr 2021 14:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE8306120F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76A0A6ECC9; Thu, 1 Apr 2021 14:37:33 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 497A16ECC9; Thu, 1 Apr 2021 14:37:31 +0000 (UTC) IronPort-SDR: KeMrh4J7Qj8hJUOKFR0FykFshIrICCLOBRRgzftFIitiScF8hvxHzXBZaAt58nvJlzHUuEkrOp dZbjNSIYQ4oQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="188996622" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="188996622" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:37:31 -0700 IronPort-SDR: kFaycvYi3nm4pN/GEZyefiUDUu1pEI2COak6fv/rtvRKD/JlEbwLf6Y95+xMrMzlGiGNlKwVD3 GogpIhMcN2oA== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="419225318" Received: from jkrzyszt-mobl1.ger.corp.intel.com ([10.213.28.167]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:37:29 -0700 From: Janusz Krzysztofik To: igt-dev@lists.freedesktop.org Date: Thu, 1 Apr 2021 16:36:42 +0200 Message-Id: <20210401143643.7867-5-janusz.krzysztofik@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210401143643.7867-1-janusz.krzysztofik@linux.intel.com> References: <20210401143643.7867-1-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [RFC PATCH i-g-t 5/6] tests/core_hotunplug: Add 'PRIME handle' variants X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Even if all device file descriptors are closed on device hotunbind / hotunplug, PRIME exported objects may still exists, referenced by still open dma-buf file descriptors. Add subtests that keep such descriptor open on device hotunbind / hotunplug. Signed-off-by: Janusz Krzysztofik --- tests/core_hotunplug.c | 104 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 104 insertions(+) diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index 6f3b3b3d3..0cb1267ae 100644 --- a/tests/core_hotunplug.c +++ b/tests/core_hotunplug.c @@ -782,6 +782,86 @@ static void userptr_hotunplug_lateclose(struct hotunplug *priv) igt_fail_on_f(munmap(ptr, 4096), "Userptr unmap failure!"); } +static void prime_hotunbind_lateclose(struct hotunplug *priv) +{ + uint32_t handle; + int dmabuf, ret; + + igt_require(priv->fd.drm = -1); + priv->fd.drm = local_drm_open_driver(false, "pre-", " for prerequisites check"); + + igt_require_intel(priv->fd.drm); + igt_require_gem(priv->fd.drm); + priv->fd.drm = close_device(priv->fd.drm, "", "pre-checked "); + + pre_check(priv); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot unbind"); + + local_debug("%s\n", "creating and PRIME-exporting a GEM object"); + handle = gem_create(priv->fd.drm, 4096); + dmabuf = prime_handle_to_fd(priv->fd.drm, handle); + + ret = local_gem_close(priv->fd.drm, handle); + priv->fd.drm = close_device(priv->fd.drm, "", "exported "); + + if (priv->fd.drm != -1) { + igt_ignore_warn(close(dmabuf)); + igt_assert_eq(priv->fd.drm, -1); + } + + /* once device close succeeds, take care of open dmabuf like if it was a device fd */ + priv->fd.drm = dmabuf; + igt_assert_f(!ret, "gem_close failed with errno %d\n", ret); + + driver_unbind(priv, "hot ", 0); + + igt_debug("late closing the PRIME file descriptor\n"); + dmabuf = local_close(dmabuf, "PRIME file descriptor late close failure"); + priv->fd.drm = dmabuf; + igt_assert_eq(dmabuf, -1); +} + +static void prime_hotunplug_lateclose(struct hotunplug *priv) +{ + uint32_t handle; + int dmabuf, ret; + + igt_require(priv->fd.drm = -1); + priv->fd.drm = local_drm_open_driver(false, "pre-", " for prerequisites check"); + + igt_require_intel(priv->fd.drm); + igt_require_gem(priv->fd.drm); + priv->fd.drm = close_device(priv->fd.drm, "", "pre-checked "); + + pre_check(priv); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot unplug"); + + local_debug("%s\n", "creating and PRIME-exporting a GEM object"); + handle = gem_create(priv->fd.drm, 4096); + dmabuf = prime_handle_to_fd(priv->fd.drm, handle); + + ret = local_gem_close(priv->fd.drm, handle); + priv->fd.drm = close_device(priv->fd.drm, "", "exported "); + + if (priv->fd.drm != -1) { + igt_ignore_warn(close(dmabuf)); + igt_assert_eq(priv->fd.drm, -1); + } + + /* once device close succeeds, take care of open dmabuf like if it was a device fd */ + priv->fd.drm = dmabuf; + igt_assert_f(!ret, "gem_close failed with errno %d\n", ret); + + device_unplug(priv, "hot ", 0); + + igt_debug("late closing the PRIME file descriptor\n"); + dmabuf = local_close(dmabuf, "PRIME file descriptor late close failure"); + priv->fd.drm = dmabuf; + igt_assert_eq(dmabuf, -1); +} + /* Main */ igt_main @@ -1015,6 +1095,30 @@ igt_main recover(&priv); } + igt_fixture + post_healthcheck(&priv); + + igt_subtest_group { + igt_describe("Check if the driver can be cleanly unbound from a device with a still open PRIME-exported object, then released"); + igt_subtest("prime-hotunbind-lateclose") + prime_hotunbind_lateclose(&priv); + + igt_fixture + recover(&priv); + } + + igt_fixture + post_healthcheck(&priv); + + igt_subtest_group { + igt_describe("Check if a device with a still open PRIME-exported object can be cleanly unplugged, then released"); + igt_subtest("prime-hotunplug-lateclose") + prime_hotunplug_lateclose(&priv); + + igt_fixture + recover(&priv); + } + igt_fixture { post_healthcheck(&priv);