| Message ID | 20210407122337.77493-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] drm/i915: Include only needed headers in ascii85.h | expand |
On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The ascii85.h is user of exactly two headers, i.e. math.h and types.h. > There is no need to carry on entire kernel.h. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> That's hardly drm/i915 specific! Reviewed-by: Jani Nikula <jani.nikula@intel.com> But who's going to pick it up and, hopefully, change the subject prefix to ascii85 or something? > --- > include/linux/ascii85.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h > index 4cc40201273e..83ad775ad0aa 100644 > --- a/include/linux/ascii85.h > +++ b/include/linux/ascii85.h > @@ -8,7 +8,8 @@ > #ifndef _ASCII85_H_ > #define _ASCII85_H_ > > -#include <linux/kernel.h> > +#include <linux/math.h> > +#include <linux/types.h> > > #define ASCII85_BUFSZ 6
On Wed, Apr 07, 2021 at 03:46:37PM +0300, Jani Nikula wrote: > On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The ascii85.h is user of exactly two headers, i.e. math.h and types.h. > > There is no need to carry on entire kernel.h. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > That's hardly drm/i915 specific! It was originated from i915! > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Thanks! > But who's going to pick it up and, hopefully, change the subject prefix > to ascii85 or something? It's drm specific. Should I leave drm and resend? Or what is the general rule for drm misc changes?
On Wed, Apr 07, 2021 at 04:40:10PM +0300, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 03:46:37PM +0300, Jani Nikula wrote: > > On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > The ascii85.h is user of exactly two headers, i.e. math.h and types.h. > > > There is no need to carry on entire kernel.h. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > That's hardly drm/i915 specific! > > It was originated from i915! > > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > Thanks! > > > But who's going to pick it up and, hopefully, change the subject prefix > > to ascii85 or something? > > It's drm specific. Should I leave drm and resend? Or what is the general rule > for drm misc changes? Since the topic comes up about drm misc, can somebody approve push access from me to that? https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/311
On Wed, Apr 07, 2021 at 03:23:37PM +0300, Andy Shevchenko wrote: > The ascii85.h is user of exactly two headers, i.e. math.h and types.h. > There is no need to carry on entire kernel.h. It seems DRM has strict rules about what's going thru DRM tree and this one, while being used only for DRM drivers and been originated as i915 code, in a stale position right now. Who can take it, please? (It's Rb by Jani) I Cc'ed this to Andrew, if he is okay to expedite it, and to Rob, who is the committer of the original move patch. Personally to me DRM seems the best match, but... see above. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/ascii85.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h > index 4cc40201273e..83ad775ad0aa 100644 > --- a/include/linux/ascii85.h > +++ b/include/linux/ascii85.h > @@ -8,7 +8,8 @@ > #ifndef _ASCII85_H_ > #define _ASCII85_H_ > > -#include <linux/kernel.h> > +#include <linux/math.h> > +#include <linux/types.h> > > #define ASCII85_BUFSZ 6 > > -- > 2.30.2 >
Btw, can someone please add a few comments to ascii85.h? I have no idea WTF "ascii85" is, why it matters and how the two helpers should be used.
diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h index 4cc40201273e..83ad775ad0aa 100644 --- a/include/linux/ascii85.h +++ b/include/linux/ascii85.h @@ -8,7 +8,8 @@ #ifndef _ASCII85_H_ #define _ASCII85_H_ -#include <linux/kernel.h> +#include <linux/math.h> +#include <linux/types.h> #define ASCII85_BUFSZ 6
The ascii85.h is user of exactly two headers, i.e. math.h and types.h. There is no need to carry on entire kernel.h. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/ascii85.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)